Mass approve/ reject functionality and UI changes for request table#335
Open
Mass approve/ reject functionality and UI changes for request table#335
Conversation
- Add row/select-all checkboxes and batch approve/reject buttons in instructor requests table - Add mass_approve and mass_reject routes + controller actions with JSON responses - Extend Stimulus controller for batch selection/action handling with DataTable updates - Add controller specs for mass endpoints - Remove hardcoded export host and build environment-safe request links
- align multi-line message assignment for RuboCop - update controller specs to use response.parsed_body and contain_exactly - use class_double for CanvasFacade.from_user stubbing
…oxes UI to toggles to match course settings and Approved Extended toggles
Author
|
Dear Professor @armandofox and Professor @cycomachead, Basim and I have added the feature to mass approve/ deny requests manually and changed approve/deny backend to AJAX workflow instead of full page reloads per berkeley-cdss#274 request. We also pulled UI changes from Igor's branch and added some UI changes (as noted in summary) for the requests page. Your review is appreciated. Sincerely, Anthony Dam |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Info
Allow course staff member to mass select and approve/deny requests manually. Also, allow approve/deny requests without refreshing the whole page because that is slow.
To complete this tasks. We divided work into 3 user stories:
1. Make approve / reject be AJAX request and refresh the table instead of the whole page like the current HTTP request / form submission
2. Create the UI checkboxes to select multiple extensions and potentially an option to mass select
3. Update backend to allow mass auto or mass decline
Summary
mass_approveandmass_rejectendpoints returning JSON for AJAX updates.Testing