Skip to content

docs: correct series mapping to match the chart builder, and two custom-roles details - #11521

Open
igorlukanin wants to merge 18 commits into
masterfrom
igor/cub-3619-docs-record-videos-for-the-docs-pages-that-need-motion
Open

docs: correct series mapping to match the chart builder, and two custom-roles details#11521
igorlukanin wants to merge 18 commits into
masterfrom
igor/cub-3619-docs-record-videos-for-the-docs-pages-that-need-motion

Conversation

@igorlukanin

@igorlukanin igorlukanin commented Aug 11, 2026

Copy link
Copy Markdown
Member

Corrects documentation that does not match what the product does.

Series mapping

The page described a drag-and-drop model the chart builder does not have. Every encoding channel is a dropdown (ChannelControlsSection renders a Select), there is no "Available fields" list anywhere in the app, and there is no field token to drag out of a slot. Four claims were affected:

  • Assigning a field is picking from a dropdown, not dragging from a list.
  • Multiple measures come from setting Color to Series (a fold transform), not from dragging more measures into Y. Added that the channel is pinned while in that mode.
  • Removing a field is the dropdown's clear control.
  • Dropped the Size channel row — the Vega fields builder renders X, Y, Color, Tooltip, data labels and small multiples, with no size channel. Also narrowed Color's applicability, which is excluded for boxplot.

The two screenshot placeholders on the page were rewritten to describe the UI that actually exists.

Tooltips

The same drag-and-drop model was stated verbatim on the tooltips page, and was wrong in a further two ways. TooltipFieldsSection renders one row per field — a Select plus an × — behind a + Tooltip button, so there is no reordering at all. Disabling is the switch on the section header, and re-enabling restores the automatic tooltip rather than the field list that was configured.

Scatter and map

Both pages documented a Size channel. They are not the same case:

  • Scatter cannot assign one. encoding.size is read by VegaStyleBuilder to show a legend section, but no Fields-tab control ever writes it, so size is reachable only through the Vega spec editor. The page now says that.
  • Map genuinely has the control — a Custom size measure select in MapChartBuilder — so the channel stays. Only its claim of a configurable minimum/maximum radius was removed; the real controls are Default size and Custom size.

Custom roles

  • The auto-bump tooltip is "Selected permissions require Developer access"; the page quoted different wording.
  • The rule said any action "stronger than Access deployment" bumps the Base Role to Developer. actionsWithoutDeveloperRequirement exempts three: DeploymentRead, DeploymentAgentRead, and DownloadData. Reworded to name all three, which the Tip below it already did for DeploymentAgentRead.
  • Both action tables were incomplete. The builder offers ten deployment-scoped actions and the page documented eight, missing SqlRunnerRead, DeploymentAgentRead, and PreAggregationBuild — while the reference catalog opens with "every action a custom role can grant". All ten are now in both tables, in the builder's group order.
  • Making the rule closed-form exposed a walkthrough that could not be followed. Create an Explorer for a single deployment picked Explorer as the Base Role, then told the reader to check Access query history — which is APMRead, not exempt, so the role would jump to Developer and disable the Explorer option chosen two steps earlier. Corrected the step.

@igorlukanin
igorlukanin requested a review from keydunov as a code owner August 11, 2026 04:59
@mintlify

mintlify Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
cubed3 🟢 Ready View Preview Aug 11, 2026, 5:00 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@claude

claude Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 1m 40s —— View job


Review complete — 3 findings (0 blocking, 3 medium: cross-page inconsistencies)

Corrections themselves look right; each one leaves a sibling page or table stating the old model.

Full review

Todos

  • Gather context (PR diff, both changed files, surrounding docs)
  • Classify request → code review, no implementation
  • Verify claims against repo (chart builder source is not in this repo; checked what is)
  • Check for stale contradictions on sibling pages
  • Check for existing Claude review threads to dedupe/resolve (none exist)
  • Post inline comments + summary

What I could and could not verify

The Cube chart builder frontend and the roles UI are not in this repo, so ChannelControlsSection, the "Series" fold transform, and the tooltip wording are unverifiable here — I took those on the author's word. What I could check is internal consistency of the docs, and DeploymentAgentRead does appear in docs-mintlify/api-reference/api.yaml:7814, which corroborates the custom-roles change.

I also confirmed the ## Multiple measures on Y## Multiple measures on one chart heading rename breaks no links — nothing in the repo references #multiple-measures-on-y.

Findings

# File Issue
1 series-mapping.mdx:14-16 Size row removed, but scatter.mdx:24,30,32 and map.mdx:42,51 still document a Size channel (and a "size field token")
2 series-mapping.mdx:35-37 tooltips.mdx:20-22 still describes dragging from Available fields and clicking × on a "field token" — the exact model this PR removes, for a channel this page now calls a dropdown
3 custom-roles.mdx:130 Access AI agents added to the Tip but absent from both the granular Actions table (112–122) and the catalog table (245–258), which claims to list every action

Details and suggested fixes are in the inline comments.

Smaller notes (not worth blocking)

  • The first screenshot placeholder (line 8) now lists "X, Y, Color and Tooltip", but the channel table also has Split by and Theta. If the screenshot is meant to show the whole tab, the caption undersells it.
  • Line 33 says the Color channel "stays pinned to Series and cannot be pointed at another column", while the Removing a field section says any channel is cleared with its ×. A reader in multi-series mode won't know how to get out of it — one clause on how to leave the mode would close that.
  • The frontmatter description correctly drops "size" but still omits "split by", same as before this PR — pre-existing, mentioning only for completeness.

Non-applicable review dimensions

Security, performance, and test coverage don't apply — this is a 13/12-line docs-only diff with no code, no config, and no navigation (docs.json) changes. Both files are existing pages edited surgically, which matches docs-mintlify/CLAUDE.md's preference for editing over adding.

• branch `igor/cub-3619-docs-record-videos-for-the-docs-pages-that-need-motion`

Comment thread docs-mintlify/docs/explore-analyze/charts/configuration/series-mapping.mdx Outdated
Comment thread docs-mintlify/admin/users-and-permissions/custom-roles.mdx Outdated
@claude

claude Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 1m 53s —— View job


Re-review after a2aeb71 — all 3 prior findings addressed; 2 new medium findings

The follow-up commit fixed every issue from the last pass. Two new internal contradictions came in with it.

Full review

Todos

  • Diff the new commit against origin/master
  • Check prior review threads (all 3 already resolved by author)
  • Verify the four new action names against api-reference/api.yaml
  • Re-check cross-page consistency for Size / drag-and-drop / tooltips
  • Post inline comments + summary

Prior findings — resolved

# Was Now
1 scatter.mdx / map.mdx still documented a Size channel scatter.mdx:24-26 now says the Fields tab has no Size channel and routes readers to the Vega spec editor + the Style-tab Size legend; map.mdx:42,51 renamed to Custom size with the Default-size fallback explained. The stale "size field token" screenshot placeholder is gone.
2 tooltips.mdx:20-22 still described dragging from Available fields Rewritten to the row/dropdown model, plus + Tooltip, the per-row ×, and the note that toggling the section off and back on restores the automatic tooltip. The dropped Reorder fields row is correctly reflected in the frontmatter-adjacent intro ("and in what order" removed).
3 DeploymentAgentRead mentioned only in the Tip Added to the granular Actions table (custom-roles.mdx:122) and the catalog (:261). The commit went further and added SqlRunnerRead and PreAggregationBuild, and re-ordered both tables to match each other.

Verification

All four action names check out against the RoleWithAccess.actions enum in docs-mintlify/api-reference/api.yaml:7791-7814APMRead, PreAggregationBuild, SqlRunnerRead, DeploymentAgentRead. The catalog table's ordering now mirrors the Actions table, which makes the two easy to diff by eye.

The chart-builder frontend still isn't in this repo, so the UI claims (size encoding surfacing a Style-tab Size section, the + Tooltip button, the toggle-restores-automatic behavior) remain on the author's word — I checked internal consistency only. Repo-wide grep for Available fields and field token across docs-mintlify/ now returns nothing; the remaining drag hits are table.mdx, pie.mdx, and kpi.mdx, all about genuinely different UI (column reorder, pivot drop zone, radius slider, KPI block handles).

New findings

# File Issue
1 custom-roles.mdx:71 The auto-bump rule still says any action "stronger than Access deployment" forces Developer, while the Tip at :133 names three exemptions. Adding a second exception turns a rounding into a contradiction.
2 series-mapping.mdx:23,37 "Each channel is a dropdown" / "the × on its dropdown" covers Tooltip, which tooltips.mdx — rewritten in this same PR — describes as a repeatable row list with one dropdown per row.

Both have suggested edits in the inline comments.

Smaller notes (not worth blocking)

  • scatter.mdx:24 enumerates the Fields tab as "X, Y, Color, tooltips, data labels, and small multiples", but the channel table in series-mapping.mdx:12-19 has no data labels row. One of the two enumerations is incomplete.
  • series-mapping.mdx:8 — the screenshot caption still lists only "X, Y, Color and Tooltip" while the table also has Split by and Theta. Carried over from the previous pass.
  • series-mapping.mdx:33 — still no stated way out of multi-series mode once Color is pinned to Series. Carried over.
  • series-mapping.mdx:18 says Tooltip (singular); tooltips.mdx calls the UI section Tooltips. Worth matching the product label.
  • custom-roles.mdx:133 — the serial-comma / 1:1 reason mapping suggestion from last time was applied. Nice.

Non-applicable review dimensions

Security, performance, and test coverage don't apply — docs-only, 37/32 lines, no code, config, or docs.json navigation changes. All five files are existing pages edited surgically, matching docs-mintlify/CLAUDE.md's preference for editing over adding.

• branch `igor/cub-3619-docs-record-videos-for-the-docs-pages-that-need-motion`

Comment thread docs-mintlify/admin/users-and-permissions/custom-roles.mdx
Comment thread docs-mintlify/docs/explore-analyze/charts/configuration/series-mapping.mdx Outdated
@claude

claude Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 1m 31s —— View job


Re-review after 815cd9a — both prior findings fixed; 1 new medium finding

The two contradictions from the last pass are closed. Tightening the auto-bump rule into a closed list surfaced a conflict with a walkthrough on the same page.

Full review

Todos

  • Diff 815cd9a against its parent and against origin/master
  • Check prior review threads (all 5 already resolved by author — nothing stale to resolve)
  • Re-verify the action catalog against api-reference/api.yaml
  • Re-check cross-page consistency for Tooltip / auto-bump
  • Post inline comment + summary

Prior findings — resolved

# Was Now
1 Auto-bump rule said "stronger than Access deployment" while the Tip named three exemptions custom-roles.mdx:71 now enumerates all three, so the Tip at :133 reads as a restatement rather than a contradiction
2 "Each channel is a dropdown" / "the × on its dropdown" contradicted the row-list model in tooltips.mdx series-mapping.mdx:23 carves Tooltip out with a link to the sibling page, and :37 explains that the tooltip × removes one row

Verification

Both tables in custom-roles.mdx are now consistent with each other and with the RoleWithAccess.actions enum in api-reference/api.yaml — 12 granular deployment actions plus All, in the same order in the Actions table (:112–125) and the catalog (:250–264). DownloadData, DeploymentAgentRead, SqlRunnerRead, PreAggregationBuild all check out at api.yaml:7786,7792,7799,7814.

The role builder and chart frontend still aren't in this repo, so which actions actually trigger the bump is unverifiable here — that's exactly what the new finding turns on.

New finding

# File Issue
1 custom-roles.mdx:71 The exemption list is now exactly three actions, but the Create an Explorer walkthrough at :175 has an Explorer base role checking Access query history (APMRead) — not exempt, so that step would force Developer and disable the Explorer chosen at :169. Same question for View data model (SchemaRead).

Details and both possible fixes are in the inline comment.

Smaller notes (not worth blocking)

  • series-mapping.mdx:18 lists the Tooltip channel's applicable types as "All types", but tooltips.mdx:12 scopes tooltips to the Vega-based types (bar, line, area, scatter, heatmap, boxplot) plus map — which leaves out pie, table, and KPI. Untouched by this commit, but the two pages now sit one link apart.
  • series-mapping.mdx calls the channel Tooltip (singular) while tooltips.mdx calls the UI section Tooltips. Carried over from the last pass.
  • series-mapping.mdx:8 — screenshot caption still lists only "X, Y, Color and Tooltip" while the table also has Split by and Theta. Carried over.
  • series-mapping.mdx:33 — still no stated way out of multi-series mode once Color is pinned to Series. Carried over.

Non-applicable review dimensions

Security, performance, and test coverage don't apply — docs-only, no code, config, or docs.json navigation changes. This commit touches 2 lines across 2 existing pages.

• branch `igor/cub-3619-docs-record-videos-for-the-docs-pages-that-need-motion`

Comment thread docs-mintlify/admin/users-and-permissions/custom-roles.mdx
@claude

claude Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 1m 4s —— View job


Re-review after cc78e99 — prior finding fixed; no new findings

Full review

Todos

  • Diff cc78e99 against its parent and origin/master
  • Check prior review threads (all 6 resolved by the author — nothing stale to resolve)
  • Re-check the walkthrough against the auto-bump rule and both tables
  • Confirm no new cross-page contradictions
  • Post summary

Prior finding — resolved

The Explorer walkthrough at custom-roles.mdx:175 now takes the first branch I suggested: it drops Access query history as an optional add-on and states the bump explicitly.

Check Access deployment so the user can open the deployment. Add Access AI agents or Download data if they need them — those three are the actions an Explorer can hold. Anything else, Access query history included, forces the Base Role up to Developer.

That agrees exactly with the rule at :71 and the Tip at :133 — the same three actions, in the same order, in all three places. Naming APMRead as the counter-example is the right choice, since it's the action a reader would most plausibly assume is Explorer-safe (it's read-only) and it's the one the walkthrough used to recommend.

The other two walkthroughs stay consistent: the Viewer one (:156) checks only Access deployment, and the Developer one (:193) has a Confirm the auto-bump step that expects the bump.

Verification

Repo-wide, Access query history / APMRead / SchemaRead now appear only in custom-roles.mdx (the two tables at :124/:263, :118/:257, and this walkthrough line) — no other page claims an Explorer can see query history, so the tightened rule doesn't strand a sibling. admin/monitoring/query-history.mdx documents the feature without asserting a role.

The role builder is not in this repo, so which actions actually sit in actionsWithoutDeveloperRequirement remains on the author's word — I verified internal consistency only. SchemaRead, the other read-only action I flagged last time, is covered by the "Anything else" clause and isn't recommended anywhere for a Viewer or Explorer.

Smaller notes (not worth blocking)

  • custom-roles.mdx:175 — "those three are the actions an Explorer can hold" is true of Viewers too. "the only deployment actions a Viewer or Explorer can hold" would match the Tip's framing, and "those three" reads slightly loose when only two of the three appear in the preceding clause.
  • series-mapping.mdx:33 — still no stated way out of multi-series mode once Color is pinned to Series. Carried over.
  • series-mapping.mdx:18 — the Tooltip channel's applicable types are "All types", while tooltips.mdx:12 scopes tooltips to the Vega types plus map. Carried over.
  • series-mapping.mdx:8 — screenshot caption lists "X, Y, Color and Tooltip" but the table also has Split by and Theta. Carried over.
  • series-mapping.mdx says Tooltip (singular); tooltips.mdx calls the section Tooltips. Carried over.

All five are pre-existing or cosmetic; none contradicts another page.

Non-applicable review dimensions

Security, performance, and test coverage don't apply — docs-only, one line changed in one existing page, no code, config, or docs.json navigation changes.

• branch `igor/cub-3619-docs-record-videos-for-the-docs-pages-that-need-motion`

@igorlukanin

Copy link
Copy Markdown
Member Author

Went through the carried-over notes against the builder rather than the page, and three of them were real product mismatches rather than wording:

  • Multi-series. The page had the direction backwards: you don't get there by setting Color to Series. foldTransform is derived from the spec (VegaTransformBuilderContext.tsx), the Color control is disabled and pinned when a fold exists, and the measure channel is replaced by a Series section. That section's per-row × is the missing exit — dropping to one measure calls unFold and the chart goes back to single-series. Documented both.
  • Tooltip is not "All types". Table, KPI and HTML have no tooltip control at all. Pie and map both use a checklist popover, not the field rows this page describes, and neither has the on/off switch. Scoped the mechanism sections and said what pie/map do instead.
  • Pie doesn't use X/Y/Color. Its Fields tab is Rings / Measure / Tooltips, and the innermost ring is the colour dimension. The table's Theta row was a name that appears nowhere in the UI — the control is labelled Measure.

Also renamed Split by to Small multiples in the channel table: that's the section heading, "Split by" is only the picker's placeholder, which is what small-multiples.mdx already says.

All in 8b7b9bb759.

@claude

claude Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 2m 14s —— View job


Re-review after 8b7b9bb — 4 carried-over notes closed; 2 new medium findings

Full review

Todos

  • Diff 8b7b9bb against its parent and origin/master
  • Check prior review threads (all 6 resolved by the author — nothing stale to resolve)
  • Re-check cross-page consistency for the renamed channels, pie, and tooltips
  • Post inline comments + summary

Carried-over notes — closed by this commit

Was Now
Screenshot caption listed only "X, Y, Color and Tooltip" while the table also had Split by and Theta :8 now lists X, Y, Color, Small multiples and Tooltip, which matches the table exactly
Tooltip channel claimed "All types" while tooltips.mdx scoped it to Vega types plus map :18 now scopes it to "Vega-based types, pie, and map — but not table, KPI, or HTML", and tooltips.mdx:12 was widened to include pie in the same commit
No stated way out of multi-series mode once Color is pinned to Series :36 adds the exit path
Tooltip (singular) vs the Tooltips section label Both pages now use Tooltips for the UI section and reserve Tooltip for the channel; :17 handles the same split for Small multiples / Split by explicitly

Renaming Split bySmall multiples agrees with small-multiples.mdx:14 ("The Small multiples section appears in the Fields tab") while the "its dropdown is labelled Split by" clause keeps :16 and :22 of that page findable. Dropping the Theta (pie) row strands nothing — Theta now appears nowhere in docs-mintlify/.

New findings

# File Issue
1 series-mapping.mdx:32-36 The rewrite removes the only statement of how to enter multi-series mode (was: "set the Color channel to Series"). The one page that still documents entry — series-configuration.mdx:6,22 — calls it the "Y-axis section" and says "Add two measures to the Y axis", the model this PR's description calls wrong.
2 series-mapping.mdx:20 Pie Rings and Measure appear nowhere else in the docs, and chart-types/pie.mdx contradicts the innermost-ring color rule ("colored using the active color palette in palette order, matched to the sort order of your query results") while never mentioning rings at all.

Both have suggested directions in the inline comments.

Verification

The chart builder frontend isn't in this repo, so the UI claims new in this commit — the Rings/Measure pie panel, the checklist tooltip control on pie and map, the absence of a tooltip switch there — remain on the author's word. What I checked is internal consistency:

  • map.mdx:86-88 documents a Tooltips section and links to tooltips.mdx without asserting rows or ordering, so the new pie/map checklist paragraph doesn't contradict it.
  • "Table, KPI, and HTML charts have no tooltip control" holds against those three pages; table.mdx:48 mentions a hover tooltip for truncated cells, but that's cell-overflow text, not the configurable channel.
  • docs.json is untouched, and no page links to #multiple-measures-on-y or any other heading this PR renamed.

Smaller notes (not worth blocking)

  • scatter.mdx:24 enumerates the Fields tab as "X, Y, Color, tooltips, data labels, and small multiples", but the channel table here has no data labels row. Defensible if data labels aren't a channel, but the two enumerations read as if they're the same list. Carried over.
  • tooltips.mdx:12 now says the default tooltip contains "the fields assigned to its channels (X, Y, Color)" and includes pie in the enabled-by-default list — but series-mapping.mdx:20 says pie has none of those three channels, leaving a pie's default tooltip contents unstated.
  • series-mapping.mdx:3 — the frontmatter description still reads "X axis, Y axis, color, and tooltips" and omits small multiples. Pre-existing.

Non-applicable review dimensions

Security, performance, and test coverage don't apply — docs-only, 17/9 lines across two existing pages, no code, config, or docs.json navigation changes.

• branch `igor/cub-3619-docs-record-videos-for-the-docs-pages-that-need-motion`

Comment thread docs-mintlify/docs/explore-analyze/charts/configuration/series-mapping.mdx Outdated
Comment thread docs-mintlify/docs/explore-analyze/charts/configuration/series-mapping.mdx Outdated
@claude

claude Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 2m 3s —— View job


Re-review after b0771e7 — 1 prior finding fixed, 1 half-fixed; 2 new medium findings

Full review

Todos

  • Diff b0771e7 against its parent and the whole PR
  • Check prior review threads (all 8 resolved by the author — nothing stale to resolve)
  • Verify the two prior findings are closed
  • Re-check cross-page consistency (pie, series-configuration, tooltips)
  • Post inline comments + summary

Prior findings

# Was Now
1 The multi-series section said how to leave the mode but never how to enter it, and series-configuration.mdx called the section "Y-axis section" series-configuration.mdx:6 now covers both cases ("With one measure that is the Y-axis section; with several, the Y channel is replaced by a Series section") and cross-links here, so the two pages name the same thing. series-mapping.mdx:32 restores an entry statement — but see new finding 1: it's an action with no control behind it. Half-fixed.
2 Pie Rings / Measure existed only in one clause here, and pie.mdx contradicted the innermost-ring color rule The clause was split so the palette does the coloring and the ring only picks the dimension, which removes the direct contradiction. But the sentence now says this is "as described on the pie & donut page", and that page still never mentions rings — see new finding 3. Half-fixed.

New findings

# File Issue
1 series-mapping.mdx:32 "Put more than one measure on the Y axis" is an action with no control: line 24 says each channel is a single dropdown, Tooltip being the only exception. Mirror image of the gap the last commit had.
2 series-mapping.mdx:34 Color pinned to Series in multi-series mode vs series-configuration.mdx:30-32, which says the per-series color picker "has no effect when a Color channel is active" — the page line 32 links to for exactly those settings.
3 series-mapping.mdx:20 The new "as described on the [pie & donut] page" pointer cites a claim pie.mdx:28-30 doesn't make; Rings is still defined nowhere but this clause.

All three have suggested edits in the inline comments.

Verification

The chart builder isn't in this repo, so the product claims new in this commit — that a second Y measure is what triggers the fold, that a pie's default tooltip spans the query rather than a channel set — remain on the author's word; I checked internal consistency only.

What holds up: Theta and Split by-as-a-section still appear nowhere in docs-mintlify/, small-multiples.mdx:14 agrees with the renamed channel row, and no page links to a heading this PR renamed. custom-roles.mdx is untouched by this commit and its two tables still match the RoleWithAccess.actions enum in api-reference/api.yaml:7786-7814. docs.json is untouched.

Smaller notes (not worth blocking)

  • tooltips.mdx:14 — "covers every member of the query … any member you have not unchecked" uses member, which isn't this section's vocabulary (the rest of the page says field and column; the only other chart-docs use of "member" is table.mdx:184, for drill members). It also describes a default in terms of unchecking, which reads as the configured state. "its default tooltip includes every field in the query, in ring order" would say it plainly.
  • tooltips.mdx:14 also leans on "ring order" — the third page to reference rings without defining them. Finding 3's fix would give it something to point at.
  • scatter.mdx:24 enumerates the Fields tab as "X, Y, Color, tooltips, data labels, and small multiples", but the channel table has no data labels row. Carried over.
  • series-mapping.mdx:36 — "Removing the second-to-last one drops the chart back to a single measure" still describes the transition from the removal's perspective rather than the resulting state. Cosmetic.

Non-applicable review dimensions

Security, performance, and test coverage don't apply — docs-only, 6 lines across 3 existing pages in this commit, no code, config, or docs.json navigation changes.

• branch `igor/cub-3619-docs-record-videos-for-the-docs-pages-that-need-motion`

Comment thread docs-mintlify/docs/explore-analyze/charts/configuration/series-mapping.mdx Outdated
Comment thread docs-mintlify/docs/explore-analyze/charts/configuration/series-mapping.mdx Outdated
@claude

claude Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Claude Code is working…

I'll analyze this and get back to you.

View job run

@igorlukanin

Copy link
Copy Markdown
Member Author

Traced the per-series colour question through the builder rather than settling it on wording, and it turned out to be two different features the docs had merged into one.

Multi-series (a fold, which a query with several measures produces) renders a Series section whose rows are a locked select plus a remove button. No colour swatch, and the shared settings below the list render once for the whole group, not per row. Colours come from the palette by ordinal position — encoding.color.scale.range.

Y-axis layers (+ Y Axis) are the ones that genuinely carry per-series settings: mark type, axis assignment, stacking. series-configuration.mdx documents that model correctly but described reaching it by "adding two measures to the Y axis", which is the other path — the one with no per-series settings at all.

So series-configuration.mdx now says which of the two it is about and links across; its colour section moved to the Style tab where the swatch actually lives, and dropped "each series has an individual color picker" (with no Color channel there is one series and one mark.color). series-mapping.mdx states the palette-by-position rule instead of promising independent settings.

In 26478498cc.

@claude

claude Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 1m 42s —— View job


Re-review after 3cb3f9a — prior finding fixed; 1 new low-severity finding

Full review

Todos

  • Diff 3cb3f9a against its parent
  • Check prior review threads (all 22 resolved by the author — nothing stale to resolve, nothing to dedupe against)
  • Verify the prior finding is closed
  • Re-check cross-page consistency
  • Post inline comment + summary

Prior finding — resolved

Was Now
series-configuration.mdx:8 said that on an unlayered chart the settings on this page "are simply the chart's own settings", which folded this page's overrides into the global ones and left :6's layer scope contradicted The sentence now points outward instead of absorbing: "With no layers there is nothing to override, so a multi-series chart is configured by the global settings instead — [data labels], [stacking, and color]. Add a layer and the sections below become available to it."

That is the right direction: the three links land on the pages that actually own those settings (data-labels.mdx:12 for the Fields-tab Data Labels toggle, color-and-stacking.mdx Stacking options and Mark color), and "Add a layer and the sections below become available to it" keeps :6's scope intact rather than widening the page.

New finding

# File Issue
1 series-configuration.mdx:8 "the global settings instead" substitutes for "the sections below", but only two of this page's four sections have a counterpart in the list. Mark type override (:12) and Y axis assignment (:34) have none — so whether those two move or simply don't exist without layers is left to inference, and axes.mdx:38 routes the right axis through "the Series configuration for a specific series", which is a layer under the new model.

Suggested wording is in the inline comment. Low severity — an omission in an enumeration, not a wrong instruction.

Verification

The chart builder isn't in this repo, so whether an unlayered multi-series chart really has no per-series surface remains on the author's word. Internal consistency is what I checked:

  • Both new links resolve: data-labels.mdx and color-and-stacking.mdx exist, and each owns the global version of the setting the sentence hands to it. color-and-stacking.mdx:49-53 (Mark color) already scopes the swatch away from multi-series mode, agreeing with :32's pointer here.
  • The walkthrough at :22-26 starts at + Y Axis, so it sits in the layered branch and is unaffected by this edit.
  • series-mapping.mdx:38 and color-and-stacking.mdx:54 still state the palette-by-position rule in the same terms.
  • bar.mdx:44 and line.mdx:42 both still start the composite recipe at + Y Axis; charts/index.mdx:33 and charts/configuration/index.mdx:11 both describe this page as per-Y-axis-layer and neither promises per-series color.
  • custom-roles.mdx is untouched by this commit; its two tables still match the RoleWithAccess.actions enum in api-reference/api.yaml:7786-7814.
  • docs.json is untouched, and no page links to a heading renamed in this PR.

Smaller notes (not worth blocking)

  • :8[stacking, and color] puts the list's serial comma inside the link text, so the link reads as one item named "stacking, and color". [stacking](…#stacking-options) and [color](…#mark-color) would also deep-link to the two sections.
  • series-mapping.mdx:34 — "Layers are also what carry per-series mark types" says per-series for what the last three commits established as per-layer.
  • series-configuration.mdx:16,36,40,42,48 and axes.mdx:39, bar.mdx:60, color-and-stacking.mdx:72 — all still say "series" for the thing that carries settings, which this PR standardized on "layer". Cosmetic, but it's the vocabulary split that made rounds 5–13 ambiguous; a sweep would retire it for good.
  • scatter.mdx:24 enumerates the Fields tab as "X, Y, Color, tooltips, data labels, and small multiples", but the channel table in series-mapping.mdx has no data labels row. Carried over from ten rounds ago.

Non-applicable review dimensions

Security, performance, and test coverage don't apply — docs-only, 1 addition / 1 deletion in one existing page in this commit, no code, config, or docs.json navigation changes.

• branch [`igor/cub-3619-docs-record-videos-for-the-docs-pages-that-need-motion`](https://github.com/cube-js/cube/tree/igor/cub-3619-docs-record-videos-for-the-docs-pages-that-need-motion)

Comment thread docs-mintlify/docs/explore-analyze/charts/configuration/series-configuration.mdx Outdated
@claude

claude Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 2m 12s —— View job


Re-review after 1af65c4 — prior finding fixed; 1 new low-severity finding

Full review

Todos

  • Diff 1af65c4 against its parent
  • Check prior review threads (all 23 resolved by the author — nothing stale to resolve, nothing to dedupe against)
  • Verify the prior finding is closed
  • Re-check cross-page consistency
  • Post inline comment + summary

Prior finding — resolved

Was Now
series-configuration.mdx:8 handed the unlayered case to "the global settings", but only two of the page's four settings had a counterpart in that list — Mark type override and Y axis assignment had none, and axes.mdx:38 routed the right axis through "the Series configuration for a specific series", which is a layer under the new model :8 now splits the four: data labels, stacking, and color "come from the global [data labels] and [color & stacking] settings", while "mark type and axis assignment do not apply at all — every series is drawn with the chart's own mark, on its one Y axis." axes.mdx:39 starts the dual-axis recipe at + Y Axis and links to the layer page, so an unlayered chart is no longer sent to a control it can't reach.

Answering the two settings that don't move with "they don't exist without a layer" is the right cut — it keeps :6's layer scope intact instead of inventing a global counterpart, and it makes axes.mdx's prerequisite explicit at the top of the recipe rather than leaving it implied by the word "series".

New finding

# File Issue
1 series-configuration.mdx:8 "Add a layer and all four sections below become available to it" — there are five H2s below (Mark type override, Color, Y axis assignment, Data labels per series, Stacking override), and Color is the one that isn't per-layer per :32. A reader who counts finds five and has to infer which four.

Suggested wording is in the inline comment — naming the four settings instead of counting sections also stops the sentence from breaking if a section is ever added.

Verification

The chart builder isn't in this repo, so whether an unlayered multi-series chart really has no mark-type or axis control remains on the author's word. Internal consistency is what I checked:

  • axes.mdx:39 and series-configuration.mdx:26,34-38 now agree on the order of operations: layer first, then Left/Right. bar.mdx:44 and line.mdx:42 both already started at + Y Axis, so all four dual-axis instructions in the docs match.
  • Repo-wide, nothing routes axis assignment or mark type through anything but a layer any more — the remaining Y-axis series phrasings (series-configuration.mdx:48, color-and-stacking.mdx:72, bar.mdx:60) are all about stacking, which is genuinely per-layer, and none of them contradicts the new rule.
  • series-mapping.mdx:34 and series-configuration.mdx:8 still state the layer/fold relationship in the same terms ("a repeat of the whole set of Fields controls", "the rule above applies inside each one separately").
  • custom-roles.mdx is untouched by this commit; its two tables still match the RoleWithAccess.actions enum in api-reference/api.yaml:7786-7814.
  • docs.json is untouched, and no page links to a heading renamed in this PR.

Smaller notes (not worth blocking)

  • series-configuration.mdx:36 — "For charts with a dual Y axis, assign each series to either the Left or Right Y axis" reads as if the second axis pre-exists, while axes.mdx:39 says assigning a layer to Right is what creates it. The two are circular rather than contradictory; one of them could say which comes first.
  • axes.mdx:39 — step 1 now contains two actions ("press + Y Axis … then change its Y axis assignment"). Splitting them would keep the list one-action-per-step, as it was before.
  • series-mapping.mdx:36,40 — "While the chart is in this multi-series mode" and the exit instruction still say chart, but per :34 the fold is per layer. Carried over.
  • series-configuration.mdx:14,42,48, bar.mdx:60, color-and-stacking.mdx:72 — all still say "series" for the thing that carries settings, which this PR standardized on "layer". Cosmetic, but it's the vocabulary split that made rounds 5–14 ambiguous; a sweep would retire it for good.
  • scatter.mdx:24 enumerates the Fields tab as "X, Y, Color, tooltips, data labels, and small multiples", but the channel table in series-mapping.mdx has no data labels row. Carried over from eleven rounds ago.

Non-applicable review dimensions

Security, performance, and test coverage don't apply — docs-only, 2 additions / 2 deletions across 2 existing pages in this commit, no code, config, or docs.json navigation changes.

• branch [`igor/cub-3619-docs-record-videos-for-the-docs-pages-that-need-motion`](https://github.com/cube-js/cube/tree/igor/cub-3619-docs-record-videos-for-the-docs-pages-that-need-motion)

Comment thread docs-mintlify/docs/explore-analyze/charts/configuration/series-configuration.mdx Outdated
@claude

claude Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 1m 23s —— View job


Re-review after be645c3 — prior finding fixed; no new findings

Full review

Todos

  • Diff be645c3 against its parent
  • Check prior review threads (all 24 resolved by the author — nothing stale to resolve, nothing to dedupe against)
  • Verify the prior finding is closed
  • Re-check cross-page consistency
  • Post summary

Prior finding — resolved

Was Now
series-configuration.mdx:8 said "Add a layer and all four sections below become available to it", but there are five H2s below and Color is the one that isn't per-layer (:32) — a reader who counts finds five and has to infer which four :8 now names them: "Add a layer and it gets its own mark type, Y axis assignment, data labels, and stacking." Those are exactly the four per-layer sections (:12, :34, :40, :46), in section order, and Color is left out by omission rather than by arithmetic.

Naming instead of counting also makes the sentence robust to a section being added later, which was the reason for suggesting it.

Verification

The chart builder isn't in this repo, so which settings a layer actually carries remains on the author's word. Internal consistency is what I checked:

  • The four named settings map 1:1 onto the page's per-layer H2s, and the fifth (Color) is consistent with :32's hand-off and with color-and-stacking.mdx:49-54.
  • The preceding clause's global-settings list (data labels, stacking, color) still resolves — data-labels.mdx:12 owns the Fields-tab Data Labels toggle, color-and-stacking.mdx owns stacking and mark color — and the two settings said not to exist without a layer (mark type, axis assignment) are the two absent from that list, so the enumeration is complete in both directions.
  • axes.mdx:39 still starts the dual-axis recipe at + Y Axis, and bar.mdx:44 / line.mdx:42 still give the same three steps for the composite recipe.
  • series-mapping.mdx:34 and series-configuration.mdx:8 still state the layer/fold relationship in the same terms.
  • custom-roles.mdx is untouched by this commit; its two tables still match the RoleWithAccess.actions enum in api-reference/api.yaml:7786-7814.
  • docs.json is untouched, and no page links to a heading renamed in this PR.

Nothing new surfaced. As far as I can tell the correctness pass is complete — every claim this PR touches now has exactly one statement in the docs, and the pages that reference it agree with that statement.

Smaller notes (not worth blocking)

  • series-configuration.mdx:16,36,40,42,48, color-and-stacking.mdx:54,72, bar.mdx:60 — all still say "series" for the thing that carries settings, which this PR standardized on "layer" (## Data labels per series, "assign each series to either Left or Right", "expand the Y-axis settings for a specific series"). Cosmetic, and it's the vocabulary split that made rounds 5–15 ambiguous; a rename sweep would retire it for good.
  • series-configuration.mdx:36 vs axes.mdx:39 — "For charts with a dual Y axis, assign each series to …" reads as if the second axis pre-exists, while axes.mdx says assigning a layer to Right is what creates it. Circular rather than contradictory. Carried over.
  • series-configuration.mdx:42 — "Configure label position, font, and format independently for each series" is a per-layer claim, but data-labels.mdx:6 describes the global feature as a total above each full stack, which is a chart-level aggregate. Pre-existing; flagging only because the two now sit one link apart.
  • series-mapping.mdx:36,40 — "While the chart is in this multi-series mode" and the exit instruction still say chart, but per :34 the fold is per layer. Carried over.
  • scatter.mdx:24 enumerates the Fields tab as "X, Y, Color, tooltips, data labels, and small multiples", but the channel table in series-mapping.mdx has no data labels row. Carried over from twelve rounds ago.

Non-applicable review dimensions

Security, performance, and test coverage don't apply — docs-only, 1 addition / 1 deletion in one existing page in this commit, no code, config, or docs.json navigation changes.

• branch [`igor/cub-3619-docs-record-videos-for-the-docs-pages-that-need-motion`](https://github.com/cube-js/cube/tree/igor/cub-3619-docs-record-videos-for-the-docs-pages-that-need-motion)

@igorlukanin
igorlukanin force-pushed the igor/cub-3619-docs-record-videos-for-the-docs-pages-that-need-motion branch from be645c3 to 974e101 Compare August 17, 2026 15:09
@claude

claude Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Re-review after 974e101 — prior finding fixed; no new findings

Full review

Todos

  • Diff 974e101 against its parent
  • Check prior review threads (all 25 resolved by the author — nothing stale to resolve, nothing to dedupe against)
  • Verify the prior finding is closed
  • Re-check cross-page consistency
  • Post summary

Prior finding — resolved

Was Now
series-configuration.mdx:8 said "Add a layer and all four sections below become available to it", but five H2s follow and Color is the one that isn't per-layer (:32) :8 names them instead: "Add a layer and it gets its own mark type, Y axis assignment, data labels, and stacking." Those are exactly the four per-layer sections (:12, :34, :40, :46), in section order, and Color drops out by omission rather than arithmetic.

Naming rather than counting also matches the frontmatter at :3 word for word ("mark type, axis assignment, stacking, and data labels"), and keeps the sentence correct if a section is added later.

Verification

The chart builder isn't in this repo, so which settings a layer actually carries remains on the author's word. Internal consistency is what I checked:

  • The four named settings map 1:1 onto the page's per-layer H2s; the fifth (Color) agrees with :32's hand-off and with color-and-stacking.mdx:50-54 (Mark color, chart-level, hidden once a Color channel is active).
  • The clause's two halves are complete in both directions: data labels, stacking, and color are the three handed to the global pages (data-labels.mdx:12 owns the Fields-tab Data Labels toggle; color-and-stacking.mdx#stacking-options and #mark-color own the other two), and mark type and axis assignment are exactly the two said not to exist without a layer.
  • axes.mdx:39 still starts the dual-axis recipe at + Y Axis; bar.mdx:44 and line.mdx:42 still give the same three steps from either side.
  • series-mapping.mdx:34 and series-configuration.mdx:8 still state the layer/fold relationship in the same terms ("a repeat of the whole set of Fields controls", "the rule above applies inside each one separately").
  • custom-roles.mdx is untouched by this commit; both its tables still match the RoleWithAccess.actions enum in api-reference/api.yaml:7786-7814.
  • docs.json is untouched, and no page links to a heading renamed in this PR.

Nothing new surfaced. The correctness pass looks complete — every claim this PR touches has one statement in the docs, and the pages referencing it agree with that statement.

Smaller notes (not worth blocking)

  • series-configuration.mdx:14,42,48, color-and-stacking.mdx:72, axes.mdx:36 — all still say "series" for the thing that carries settings, which this PR standardized on "layer" (## Data labels per series, "expand the Y-axis settings for a specific series", "per Y-axis series in the Y-axis series configuration"). Cosmetic, and it's the vocabulary split that made rounds 5–16 ambiguous; a rename sweep would retire it for good.
  • series-configuration.mdx:36 vs axes.mdx:39 — "For charts with a dual Y axis, assign each series to …" reads as if the second axis pre-exists, while axes.mdx says assigning a layer to Right is what creates it. Circular rather than contradictory. Carried over.
  • series-configuration.mdx:42 — "Configure label position, font, and format independently for each series" is a per-layer claim, while data-labels.mdx:6 describes the global feature as a total above each full stack, a chart-level aggregate. Pre-existing.
  • series-mapping.mdx:36,40 — "While the chart is in this multi-series mode" and the exit instruction still say chart, but per :34 the fold is per layer. Carried over.
  • scatter.mdx:24 enumerates the Fields tab as "X, Y, Color, tooltips, data labels, and small multiples", but the channel table in series-mapping.mdx has no data labels row. Carried over from thirteen rounds ago.

Non-applicable review dimensions

Security, performance, and test coverage don't apply — docs-only, 1 addition / 1 deletion in one existing page in this commit, no code, config, or docs.json navigation changes.

View job run • branch igor/cub-3619-docs-record-videos-for-the-docs-pages-that-need-motion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant