vmm: fix VM lifecycle bug#83
Merged
phip1611 merged 4 commits intocyberus-technology:gardenlinuxfrom Feb 13, 2026
Merged
Conversation
Eventually, the VMM shuts down in the case of a successful migration. We need to prevent "migration ongoing" errors in the shutdown path. So far, I only triggered this with `ch-remote` but we didn't observe it in the (test) production environment. On-behalf-of: SAP philipp.schuster@sap.com Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
phip1611
force-pushed
the
poc-fix-bug
branch
5 times, most recently
from
4f6b722 to
2fd5636
Compare
amphi
reviewed
Feb 13, 2026
amphi
reviewed
Feb 13, 2026
If a failure happens fairly late in the migration, the VM will remain unusable. This commit uses the generic migration result check code path to resume() the VM when the VM was running before as well. I could nicely test various scenarios via `ch-remote`. On-behalf-of: SAP philipp.schuster@sap.com Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
phip1611
force-pushed
the
poc-fix-bug
branch
from
2fd5636 to
b28a0c6
Compare
Cloud Hypervisor only supports migration of running VMs. There are too many implicit assumptions in the code to fix them easily. Further, with our current knowledge, this restriction is perfectly feasible. This check makes this failure case more explicit in favor of deeply nested errors. On-behalf-of: SAP philipp.schuster@sap.com Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
On-behalf-of: SAP philipp.schuster@sap.com Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
phip1611
force-pushed
the
poc-fix-bug
branch
from
b28a0c6 to
c9f3ec0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs in the live-migration path.
Regarding the first one: This was a panic in the VMM that was happening during shutdown. Therefore, nothing critical.
The second bug: When the migration failes fairly late, the VMM might keep running but the VM is "dead" (paused). This fixes it by resuming it again.
Hints for Reviewers