Skip to content

fix(create-frontend): pin jQuery to 3.7.1 for basercms4 projects #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teppei-d wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix(create-frontend): pin jQuery to 3.7.1 for basercms4 projects #901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79099bb
fix(create-frontend): pin jQuery to 3.7.1 for basercms4 projects
teppei-d May 29, 2026
36a7ee4
fix(create-frontend): update comment to clarify colorbox incompatibility
teppei-d Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/@d-zero/create-frontend/index.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,4 +124,13 @@ describe('CLI', () => {
expect(content).toContain("startPath: '__tmpl/'");
});
});

describe('package.json', () => {
test('basercms4: jquery が 3.7.1 に固定されている', async ({ tmpDir, task }) => {
const dir = path.join(tmpDir, getName(task));
await interactiveTest(dir, 'basercms4');
const pkg = JSON.parse(fs.readFileSync(path.join(dir, 'package.json'), 'utf8'));
expect(pkg.dependencies['jquery']).toBe('3.7.1');
});
});
});
2 changes: 1 addition & 1 deletion packages/@d-zero/create-frontend/plopfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ export default async function (plop) {
delete pkg.scripts.bge;
delete pkg.devDependencies['@burger-editor/local'];
pkg.dependencies['@burger-editor/css'] = '2';
pkg.dependencies['jquery'] = 'latest';
pkg.dependencies['jquery'] = '3.7.1'; // colorbox が jQuery 4系と互換性がないため、3系の最新版に固定
pkg.dependencies['jquery-colorbox'] = '1.5';
}
pkg.scripts.postinstall = 'husky';
Expand Down