Skip to content

クラス命名の接頭辞にl-とp-を許可する#847

Merged
yusasa16 merged 7 commits into
v6from
feat/class-naming-lpc-prefix
May 14, 2026
Merged

クラス命名の接頭辞にl-とp-を許可する#847
yusasa16 merged 7 commits into
v6from
feat/class-naming-lpc-prefix

Conversation

@yusasa16
Copy link
Copy Markdown

@yusasa16 yusasa16 commented Mar 9, 2026 •
edited
Loading

デザイン作成において、Layout層とPage層の設置・ルール化を検討する。
それに伴い、それぞれの層に対応した接頭辞の追加する。

Close #846

yusasa16 added 3 commits March 9, 2026 17:05
@yusasa16
feat(markuplint-config): add l- and p- prefixes to class naming rule
659e20d 
Allow layout (l-) and page (p-) prefixes in addition to component (c-).
Prefix order in patterns: lpc.

Made-with: Cursor
@yusasa16
feat(stylelint-config): add l- and p- prefixes to class naming rule
61e8319 
Allow layout (l-) and page (p-) prefixes in addition to component (c-).
Prefix order in patterns: lpc.

Made-with: Cursor
@yusasa16
test: update expectations for lpc class naming prefix
f962488 
Made-with: Cursor
@yusasa16 yusasa16 requested review from YusukeHirao and arktds March 9, 2026 08:14
@yusasa16 yusasa16 self-assigned this Mar 9, 2026
YusukeHirao
YusukeHirao previously approved these changes Mar 9, 2026
View reviewed changes
arktds
arktds reviewed Apr 13, 2026
View reviewed changes
Comment thread packages/@d-zero/stylelint-config/name.js Outdated
Comment thread test/fixtures/stylelint/class-name.scss Outdated
Comment thread test/cli.spec.mjs Outdated
@arktds
Copy link
Copy Markdown
Collaborator

arktds commented Apr 13, 2026

@yusasa16
この README は c- のままなので変更が必要です！
https://github.com/d-zero-dev/linters/blob/dev/packages/%40d-zero/markuplint-config/README.md

"value": "/^c-(?<ComponentName>[a-z][a-z0-9]*(?:-[a-z0-9]+)*)$/"

@arktds arktds mentioned this pull request Apr 13, 2026
Open
@arktds
Copy link
Copy Markdown
Collaborator

arktds commented Apr 13, 2026

各所「コンポーネント」から「ブロック」（またはより適切な名称）へリライトしたほうが良さそうな箇所があるので、別途プルリクエスト #848 を作成しました！

@yusasa16 @arktds
Update packages/@d-zero/stylelint-config/name.js
ef91378 
Co-authored-by: arktds <ariki.tds@gmail.com>
yusasa16 and others added 3 commits April 20, 2026 10:07
@yusasa16 @arktds
Update test/fixtures/stylelint/class-name.scss
893a20d 
Co-authored-by: arktds <ariki.tds@gmail.com>
@yusasa16 @arktds
Update test/cli.spec.mjs
986c0b6 
Co-authored-by: arktds <ariki.tds@gmail.com>
@yusasa16 @claude
docs(markuplint-config): update class-naming example to include l- an…
154892c 
…d p- prefixes

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@arktds arktds self-requested a review April 20, 2026 04:58
arktds
arktds approved these changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@arktds arktds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusasa16 yusasa16 mentioned this pull request May 13, 2026
Draft
@yusasa16 yusasa16 changed the base branch from dev to v6 May 14, 2026 01:43
@yusasa16 yusasa16 merged commit b78418e into v6 May 14, 2026
2 checks passed
@yusasa16 yusasa16 deleted the feat/class-naming-lpc-prefix branch May 14, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YusukeHirao YusukeHirao YusukeHirao approved these changes

@arktds arktds arktds approved these changes

Assignees

@yusasa16 yusasa16

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

クラス命名の接頭辞にl-とp-を許可する

3 participants

@yusasa16 @arktds @YusukeHirao