small but (perhaps) useful changes on I2C#2
Open
Martinix75 wants to merge 4 commits intodaniel-j:masterfrom
Open
small but (perhaps) useful changes on I2C#2Martinix75 wants to merge 4 commits intodaniel-j:masterfrom
Martinix75 wants to merge 4 commits intodaniel-j:masterfrom
Conversation
1 -Changed by template -> proc "ic2setupnim" an detiturn PRT i2cInst 2 -Address in the procedure is now Uint8 (and not i2c Address)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1- Changed i2csetupnim () Template-> proc (with I2CInst return)
2- In the all procedures, "adress" changed by i2cadsess-> uint8 the conversion will be done after automatically)
3- Added a "Type Pull" Up, Disable, to set the pulluP (or remove it) on the I2C bus.
4- The reading and writing procedures I added the praglma {.inline.} To try to speed up the writing reading.
If you accept the changes, it will be my pleasure to write some basic examples.