Skip to content

fix: MaxRetryInterval was not propagated#1685

Merged
dapr-bot merged 2 commits intodapr:masterfrom
javier-aliaga:fix-worflow-maxRetryInterval
Mar 3, 2026
Merged

fix: MaxRetryInterval was not propagated#1685
dapr-bot merged 2 commits intodapr:masterfrom
javier-aliaga:fix-worflow-maxRetryInterval

Conversation

@javier-aliaga
Copy link
Contributor

Description

maxRetryInterval from WorkflowTaskRetryPolicy was silently dropped when converting to the durabletask RetryPolicy. This caused the runtime to use its default ~5-minute cap regardless of what the user configured.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Javier Aliaga <javier@diagrid.io>
@javier-aliaga javier-aliaga requested review from a team as code owners March 3, 2026 17:18
@javier-aliaga javier-aliaga changed the title fix: MaxRetryInterval was not propagate fix: MaxRetryInterval was not propagated Mar 3, 2026
Copy link
Collaborator

@salaboy salaboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dapr-bot dapr-bot merged commit a2877aa into dapr:master Mar 3, 2026
13 checks passed
dapr-bot pushed a commit that referenced this pull request Mar 3, 2026
Signed-off-by: Javier Aliaga <javier@diagrid.io>
(cherry picked from commit a2877aa)
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.51%. Comparing base (129c29d) to head (a0c5807).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1685      +/-   ##
============================================
+ Coverage     79.48%   79.51%   +0.03%     
- Complexity     2191     2194       +3     
============================================
  Files           237      237              
  Lines          6575     6577       +2     
  Branches        729      730       +1     
============================================
+ Hits           5226     5230       +4     
+ Misses          994      992       -2     
  Partials        355      355              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants