-
Notifications
You must be signed in to change notification settings - Fork 90
[record_use] Generate syntax #2868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with Breaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
57a1778 to
339b58d
Compare
339b58d to
248c518
Compare
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| import 'identifier.dart' show Identifier; | ||
| import 'identifier.dart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally like shows, makes it easier to grep which symbols are where. I am trying to use them by default everywhere now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds like a lot of manual churn if we don't have (a) a lint to enforce it, and (2) the auto-import features in the IDE use that, and (3) have auto-fixes.
Opt me in when we have it effortless!
It might also help with analyzer speed in our projects! 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I also would love a lint for this... @bwilkerson ;)
This PR:
(Such as
List<int?>where the nullability comes from the type in the JSON schema being defined as a["integer", "null"]rather than"integer"and the field in the dictionary being non-required.)Bug: #2681
This PR does not:
I have filed issues in [record_use] Correctness: ☂️ JSON format #1093.