fix(swift-sdk): fix spv usage#3026
Merged
QuantumExplorer merged 15 commits intofeat/iOSSupportfrom Jan 31, 2026
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
added 14 commits
January 30, 2026 15:47
…alculation, UI reports sync state correctly
… FFISyncStage variants
…it makes everything rely on the progress update callbacks
… must be decided by the SPVClient reducing usage complexity
… null ptr issue when switching networks
…ss who now wraps all the dash_svp_ffi calls (except for logging)
edefd2a to
989ead5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the sync rewrite changes are coming, this PR mainly fixes how SPVClient is being used to be align with the expected, removes ffi calls that are about to be droppped, and prepares the wrapper for the new changes. After the rewrite we can start adding the missing/not yet implemented features.
The main idea is, FFISpvClient will work as a facade for the dash spv ffi and the swift SPVClient class wraps those ffi calls with a swift interface
Issue being fixed or feature implemented
SPV Client FFI usage
What was done?
How Has This Been Tested?
Executed the tests and tested the app behavior myself
Breaking Changes
Since no tests needed to be updated I understand that all changes I made are not breaking
Checklist:
For repository code-owners and collaborators only