Skip to content

Conversation

@shumkov
Copy link
Collaborator

@shumkov shumkov commented Jan 31, 2026

Issue being fixed or feature implemented

After state transition broadcasting, we connect to a node to wait for execution result. in case if node is malicios or mailfunctioning it might return error, not return result or return close connection.

What was done?

  • Limit client side request timeout to 30 seconds and retry 3 times in case of errors.

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Chores
    • Reduced timeout for state transition result operations from 80 to 30 seconds for faster response handling.
    • Increased automatic retry attempts from zero to three for improved resilience.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions github-actions bot added this to the v3.1.0 milestone Jan 31, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 31, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
📝 Walkthrough

Walkthrough

Configuration adjustment to the WaitForStateTransitionResult gRPC transport request: timeout reduced from 80 to 30 seconds and retries increased from 0 to 3. No public API or behavioral changes.

Changes

Cohort / File(s) Summary
gRPC Request Configuration
packages/rs-dapi-client/src/transport/grpc.rs
Modified timeout and retry settings for WaitForStateTransitionResult gRPC requests: reduced timeout to 30 seconds and enabled 3 retries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hop, hop, the timeout shrinks with care,
Retries now number three, so fair!
Quick responses when networks do dare,
State transitions float through the air!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding retry logic for the wait-for-result request on deadline exceeded errors, which aligns with the timeout reduction to 30 seconds and retry increase to 3.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/retry-on-deadline

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@shumkov shumkov self-assigned this Jan 31, 2026
@shumkov shumkov moved this to In review / testing in Platform team Jan 31, 2026
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concept ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review / testing

Development

Successfully merging this pull request may close these issues.

4 participants