-
Notifications
You must be signed in to change notification settings - Fork 45
feat(sdk): retry the wait for result request on deadline exeeded #3035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3.1-dev
Are you sure you want to change the base?
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the
📝 WalkthroughWalkthroughConfiguration adjustment to the WaitForStateTransitionResult gRPC transport request: timeout reduced from 80 to 30 seconds and retries increased from 0 to 3. No public API or behavioral changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Remove `bincode` from simple-signer (used via dpp re-export, not directly) and `once_cell` from platform-version (not used at all). https://claude.ai/code/session_01GzTJ1YK7pskXNs2ipADL9X
PastaPastaPasta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
concept ACK
Issue being fixed or feature implemented
After state transition broadcasting, we connect to a node to wait for execution result. in case if node is malicios or mailfunctioning it might return error, not return result or return close connection.
What was done?
How Has This Been Tested?
None
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.