Skip to content

feat(platform-wallet): token-minting finalize from a funding path (spendable DashPay receival accounts) #4256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bfoss765 wants to merge 57 commits into from
Closed

feat(platform-wallet): token-minting finalize from a funding path (spendable DashPay receival accounts) #4256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
8f14318
feat(kotlin-sdk): split build/broadcast with reservation release for …
bfoss765 Jul 10, 2026
dd04607
fix(kotlin-sdk): bound deferred-payment token lifetime; harden regist…
bfoss765 Jul 11, 2026
f09a7e1
fix(kotlin-sdk): resolve rebase semantic conflicts onto feat/kotlin-s…
bfoss765 Jul 16, 2026
43a2414
fix(kotlin-sdk): assert native code 26 for the stale-reservation-toke…
bfoss765 Jul 17, 2026
f6fbda8
fix(kotlin-sdk): bound the deferred-payment token on the reservation'…
bfoss765 Jul 17, 2026
5c7a461
fix(kotlin-sdk): sweep deferred-payment tokens only when the final wa…
bfoss765 Jul 17, 2026
8dcd345
fix(kotlin-sdk): route deferred builds through the atomic finalize-an…
bfoss765 Jul 17, 2026
35a2335
fix(kotlin-sdk): delete the dead split register→broadcast chain
bfoss765 Jul 21, 2026
cd97c85
fix(kotlin-sdk): baseline the deferred token age on the pre-signing r…
bfoss765 Jul 21, 2026
bfd58fc
fix(kotlin-sdk): give the V2 handle and token paths one wallet-genera…
bfoss765 Jul 21, 2026
b2784e5
fix(kotlin-sdk): validate the deferred token under the lock, consume …
bfoss765 Jul 21, 2026
489e456
fix(kotlin-sdk): release deferred reservations at final-alias destroy…
bfoss765 Jul 21, 2026
9758f3c
fix(kotlin-sdk): split the conflated deferred-token error code into t…
bfoss765 Jul 21, 2026
1803197
docs(kotlin-sdk): correct buildSignedPayment KDoc to the finalize-and…
bfoss765 Jul 21, 2026
ade5cff
fix(kotlin-sdk): make the deferred payment token an owning AutoClosea…
bfoss765 Jul 21, 2026
2f596c6
style(kotlin-sdk): rustfmt wallet_manager.rs after the dead-chain del…
bfoss765 Jul 21, 2026
5eba39a
fix(kotlin-sdk): object-owning broadcast/release overloads for Signed…
bfoss765 Jul 21, 2026
8173cee
fix(kotlin-sdk): retain a releasable account handle for CoinJoin-fund…
bfoss765 Jul 22, 2026
019ec30
fix(kotlin-sdk): bind deferred-payment reservation cleanup to its own…
bfoss765 Jul 22, 2026
48d255f
fix(swift-sdk): surface deferred-token codes 26/27/28 as typed errors
bfoss765 Jul 22, 2026
4b4b7b7
chore(rust-dashcore): pin to canonical dashpay dev rev with owner-tag…
bfoss765 Jul 22, 2026
581947d
fix: renumber deferred-reservation error codes to 27/28/29
bfoss765 Jul 23, 2026
1a25d91
fix(platform-wallet): owner-guard the broadcast-reject reservation re…
bfoss765 Jul 23, 2026
bc33a61
fix(platform-wallet): enforce unique reservation ownership, stop wrap…
bfoss765 Jul 24, 2026
8612a3f
fix(platform-wallet): bind registration to correct wallet generation …
bfoss765 Jul 25, 2026
13ddeec
fix(platform-wallet): linearize wallet removal with deferred broadcas…
bfoss765 Aug 1, 2026
7fc0f24
fix(platform-wallet-ffi)!: move ErrorReservationWalletMismatch 29 -> …
bfoss765 Aug 1, 2026
5b6288d
refactor(platform-wallet-ffi): drop stale HandleStorage::any left by …
bfoss765 Aug 1, 2026
e5c9982
fix(platform-wallet): scope the lifecycle gate to the wallet generati…
bfoss765 Aug 2, 2026
b0ac945
fix(platform-wallet): remove the wallet generation by identity, not b…
bfoss765 Aug 2, 2026
a9008b2
fix(platform-wallet): move the deferred-token trio off the codes #426…
bfoss765 Aug 3, 2026
0e15cc3
fix(kotlin-sdk): stop the stray 98 arm from shadowing PlatformWallet.…
bfoss765 Aug 4, 2026
822c909
feat(platform-wallet): union-funding build_signed_payment core primitive
bfoss765 Jul 13, 2026
a341801
feat(sdk): plumb build_signed_payment through FFI, JNI, and Kotlin
bfoss765 Jul 13, 2026
57fde15
fix(platform-wallet): re-scope build_signed_payment to single-account…
bfoss765 Jul 30, 2026
298de9a
feat(platform-wallet): expose account-level derivationPath in account…
bfoss765 Jul 31, 2026
340358f
fix(platform-wallet): dust + size bounds, typed build errors, and tes…
bfoss765 Jul 31, 2026
6918bd7
fix(platform-wallet): fail closed when no wallet-level account matche…
bfoss765 Jul 31, 2026
0bdcd5e
feat(kotlin-sdk): expose release_payment_reservation for abandoned bu…
bfoss765 Aug 1, 2026
0482041
docs(ffi): drop the redundant "later ... afterwards" in the send modu…
bfoss765 Aug 3, 2026
f034df7
fix(platform-wallet): adopt #4185's WalletGeneration in the send-path…
bfoss765 Aug 3, 2026
9ea2942
fix(swift-sdk): mirror ErrorTransactionBuild (32) into the Swift resu…
bfoss765 Aug 3, 2026
d319572
style(platform-wallet): rustfmt the restacked send-path test fixtures
bfoss765 Aug 3, 2026
189f066
fix(platform-wallet): owner-guard the raw-payment reservation release
bfoss765 Aug 4, 2026
7eebbc1
fix(kotlin-sdk): release a cancelled buildSignedPayment's reservation
bfoss765 Aug 4, 2026
7cd1bf9
fix(kotlin-sdk): release reservation on JNI pack failure; harden defe…
bfoss765 Aug 4, 2026
5752e21
fix(kotlin-sdk): release the minted token on the finalize null-txid path
bfoss765 Aug 4, 2026
6591f06
feat(platform-wallet): token-minting finalize from a funding path (sp…
bfoss765 Jul 31, 2026
bb99895
test(platform-wallet): DashPay-funded split wallet fixture for the re…
bfoss765 Jul 31, 2026
e386363
fix(platform-wallet): register the funding-path payment under #4185's…
bfoss765 Aug 3, 2026
2b202bd
fix(platform-wallet): make FinalizedCorePayment a linear obligation
bfoss765 Aug 3, 2026
4fb6797
fix(platform-wallet): give signing failures their own error and FFI c…
bfoss765 Aug 1, 2026
466e765
fix(swift-sdk): mirror ErrorTransactionSigning (33) into the Swift re…
bfoss765 Aug 3, 2026
04d4e04
style(platform-wallet): rustfmt the funding-path registry and its fix…
bfoss765 Aug 3, 2026
8e6b576
fix(platform-wallet): consume the finalized payment on registration a…
bfoss765 Aug 4, 2026
974cb06
fix(kotlin-sdk): release the minted token when cancellation discards …
bfoss765 Aug 4, 2026
cb7e6fe
refactor(platform-wallet): unify the key-wallet ReservationToken alia…
bfoss765 Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 25 additions & 25 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,14 @@ members = [
]

[workspace.dependencies]
dashcore = { git = "https://github.com/dashpay/rust-dashcore", rev = "70d4bf8e36057c58e02d56769a6e9760f701dd06" }
dash-network-seeds = { git = "https://github.com/dashpay/rust-dashcore", rev = "70d4bf8e36057c58e02d56769a6e9760f701dd06" }
dash-spv = { git = "https://github.com/dashpay/rust-dashcore", rev = "70d4bf8e36057c58e02d56769a6e9760f701dd06" }
key-wallet = { git = "https://github.com/dashpay/rust-dashcore", rev = "70d4bf8e36057c58e02d56769a6e9760f701dd06" }
key-wallet-ffi = { git = "https://github.com/dashpay/rust-dashcore", rev = "70d4bf8e36057c58e02d56769a6e9760f701dd06" }
key-wallet-manager = { git = "https://github.com/dashpay/rust-dashcore", rev = "70d4bf8e36057c58e02d56769a6e9760f701dd06" }
dash-network = { git = "https://github.com/dashpay/rust-dashcore", rev = "70d4bf8e36057c58e02d56769a6e9760f701dd06" }
dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore", rev = "70d4bf8e36057c58e02d56769a6e9760f701dd06" }
dashcore = { git = "https://github.com/dashpay/rust-dashcore", rev = "8f78baa6b7979b9bea56501ad75b5a7b7150a711" }
dash-network-seeds = { git = "https://github.com/dashpay/rust-dashcore", rev = "8f78baa6b7979b9bea56501ad75b5a7b7150a711" }
dash-spv = { git = "https://github.com/dashpay/rust-dashcore", rev = "8f78baa6b7979b9bea56501ad75b5a7b7150a711" }
key-wallet = { git = "https://github.com/dashpay/rust-dashcore", rev = "8f78baa6b7979b9bea56501ad75b5a7b7150a711" }
key-wallet-ffi = { git = "https://github.com/dashpay/rust-dashcore", rev = "8f78baa6b7979b9bea56501ad75b5a7b7150a711" }
key-wallet-manager = { git = "https://github.com/dashpay/rust-dashcore", rev = "8f78baa6b7979b9bea56501ad75b5a7b7150a711" }
dash-network = { git = "https://github.com/dashpay/rust-dashcore", rev = "8f78baa6b7979b9bea56501ad75b5a7b7150a711" }
dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore", rev = "8f78baa6b7979b9bea56501ad75b5a7b7150a711" }
Comment on lines +55 to +62

@thepastaclaw thepastaclaw Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Blocking: Use a rust-dashcore revision compatible with platform-wallet

These workspace dependencies now pin rust-dashcore revision 8f78baa6b7979b9bea56501ad75b5a7b7150a711, while the current platform-wallet code still targets the API from the base branch's 70d4bf8e36057c58e02d56769a6e9760f701dd06 line. On this exact head, cargo check -p platform-wallet fails with seven errors: build_asset_lock_with_signer now expects an AssetLockFundingAccount and an additional drain argument, and production code still reads or initializes the removed AddressInfo.used, generated_at, and used_at fields. The upstream revision range confirms that 8f78baa6 contains the required owner-tagged reservation API alongside unrelated receive-address state and CoinJoin asset-lock API changes. Pin a compatible owner-reservation revision based on the platform baseline, or include the complete platform-wallet migration required by 8f78baa6; as submitted, the crate and this PR's tests cannot compile.

source: ['codex']


tokio-metrics = "0.5"

Expand Down
Loading
Loading