Skip to content

Enhance task handling and error management in models - #245

Merged
luk384090-cloud merged 4 commits into
dashscope:mainfrom
songguocola:dev/audio_0708
Jul 15, 2026
Merged

Enhance task handling and error management in models#245
luk384090-cloud merged 4 commits into
dashscope:mainfrom
songguocola:dev/audio_0708

Conversation

@songguocola

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several enhancements across the SDK, including support for a 'cancel' directive in speech synthesis, error callback handling in real-time conversations, and runtime parameter updates in multimodal dialogs. The review feedback highlights critical issues: potential NullPointerException bugs in OmniRealtimeConversation where connectLatch.get() is dereferenced without a null check, and concurrency risks in MultiModalDialog where the shared requestParamWithStream is modified without synchronization.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/main/java/com/alibaba/dashscope/audio/omni/OmniRealtimeConversation.java Outdated
Comment thread src/main/java/com/alibaba/dashscope/audio/omni/OmniRealtimeConversation.java Outdated
Comment thread src/main/java/com/alibaba/dashscope/multimodal/MultiModalDialog.java Outdated
Comment thread src/main/java/com/alibaba/dashscope/multimodal/MultiModalDialog.java Outdated
@luk384090-cloud
luk384090-cloud merged commit 882b66f into dashscope:main Jul 15, 2026
3 checks passed
@songguocola
songguocola deleted the dev/audio_0708 branch July 28, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants