chore: Bump ver: 0.5.0#9
Merged
Merged
Conversation
drmingdrmer
force-pushed
the
main
branch
7 times, most recently
from
July 19, 2026 12:43
83b35da to
2c92d93
Compare
# Summary The mvcc module's read/write/range API collapses from a namespace-scoped, per-call sequence-bounded trait zoo into a single-space view API: every `Table`, `Snapshot`, and `View` now owns exactly one key-value space, reads/writes/ranges are split into focused single-purpose traits that compose into `ViewApi`, and `View` itself implements that trait directly. # Details Removed the entire `scoped_*`/`seq_bounded_*` trait family (`ScopedApi`, `ScopedGet`, `ScopedRange`, `ScopedRead`, `ScopedSet`, `ScopedSeqBoundedGet`, `ScopedSeqBoundedIntoRange`, `ScopedSeqBoundedRange`, `ScopedSeqBoundedRangeIter`, `SeqBoundedGet`, `SeqBoundedIntoRange`, `SeqBoundedRange`, `SeqBoundedRangeIter`) along with `ViewNamespace`, `ViewKey`, `ViewValue`, and the `Commit` trait. `Table`'s own lookups already covered the point/multi-key/range cases, and key/value bounds now come from the crate's existing `MapKey`/`MapValue` traits, so this whole parallel hierarchy was redundant. In its place, `read_at_seq.rs` provides `GetAtSeq`/`RangeAtSeq` for per-call sequence-bounded reads, and `view_get.rs`/`view_set.rs`/ `view_range.rs` provide `ViewGet`/`ViewSet`/`ViewRange` for a view that owns its own sequence boundary. `ViewSet<K>: ViewGet<K>` is a supertrait, so its default `fetch_and_set()` gets `get()`/`set()` for free instead of every implementor rewriting it. `ViewApi<K>` is a blanket trait over all three, and `View<K, D>` now implements them directly instead of only exposing equivalent inherent methods. With `ViewNamespace` gone, `Table`, `Snapshot`, and `View` drop their namespace type parameter (`<S, K, V>` becomes `<K>` / `<K, D>`), and the public `Tables`/`TablesSnapshot` type aliases that named the old `BTreeMap<S, Table<K, V>>` composition are gone too — every method loses its `space` argument. - The per-namespace `increments_seq()` flag is replaced by a per-`View` `with_tombstone_seq_increment()` setting plus explicit `set_without_seq_increment` / `fetch_and_set_without_seq_increment` calls for callers that need the old opt-out behavior. - `Snapshot::commit()` is gone. `View::into_parts()` now returns `(reader, last_seq, changes)` so callers merge with `Table::merge()` instead of going through a namespace-aware commit trait. - Dropped `namespace_view_no_seq_increase_test.rs`, which only exercised the now-removed per-namespace `increments_seq()` behavior.
xp-trumpet
reviewed
Jul 19, 2026
xp-trumpet
left a comment
There was a problem hiding this comment.
@xp-trumpet partially reviewed 31 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on drmingdrmer).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
chore: Bump ver: 0.5.0
refactor: remove multi-namespace support from mvcc
Summary
The mvcc module's read/write/range API collapses from a
namespace-scoped, per-call sequence-bounded trait zoo into a
single-space view API: every
Table,Snapshot, andViewnowowns exactly one key-value space, and
Viewitself implements theresulting
ViewApitrait directly.Details
Removed the entire
scoped_*/seq_bounded_*trait family(
ScopedApi,ScopedGet,ScopedRange,ScopedRead,ScopedSet,ScopedSeqBoundedGet,ScopedSeqBoundedIntoRange,ScopedSeqBoundedRange,ScopedSeqBoundedRangeIter,SeqBoundedGet,SeqBoundedIntoRange,SeqBoundedRange,SeqBoundedRangeIter)along with
ViewNamespace,ViewKey,ViewValue, and theCommittrait.
Table's own lookups already covered the point/multi-key/rangecases, and key/value bounds now come from the crate's existing
MapKey/MapValuetraits, so this whole parallel hierarchy wasredundant. The survivors are renamed into the
view_*family, and anew
ReadAtSeqtrait (read_at_seq.rs) provides the one remainingper-call sequence-bounded read (
get_at_seq/range_at_seq).With
ViewNamespacegone,Table,Snapshot, andViewdrop theirnamespace type parameter (
<S, K, V>becomes<K>/<K, D>).Tables<K>is now a plainTable<K, V>instead ofBTreeMap<S, Table<K, V>>, so every method loses itsspaceargument.
increments_seq()flag is replaced by aper-
Viewwith_tombstone_seq_increment()setting plus explicitset_without_seq_increment/fetch_and_set_without_seq_incrementcalls for callers that need the old opt-out behavior.
Snapshot::commit()is gone.View::into_parts()now returns(reader, last_seq, changes)so callers merge withTable::merge()instead of going through a namespace-aware committrait.
View<K, D>now implementsViewRead,ViewWrite, andViewRangedirectly, delegating to its own methods, so itsatisfies the combined
ViewApibound — a compile-time assertiontest guards that.
namespace_view_no_seq_increase_test.rs, which onlyexercised the now-removed per-namespace
increments_seq()behavior.