Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions acceptance/acceptance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,10 @@ func getSkipReason(config *internal.TestConfig, configPath string) string {
return fmt.Sprintf("Disabled via RequiresUnityCatalog setting in %s (TEST_METASTORE_ID is empty)", configPath)
}

if isTruePtr(config.SkipOnUnityCatalog) && os.Getenv("TEST_METASTORE_ID") != "" {
return fmt.Sprintf("Disabled via SkipOnUnityCatalog setting in %s (TEST_METASTORE_ID is set)", configPath)
}

if isTruePtr(config.RequiresWarehouse) && os.Getenv("TEST_DEFAULT_WAREHOUSE_ID") == "" {
return fmt.Sprintf("Disabled via RequiresWarehouse setting in %s (TEST_DEFAULT_WAREHOUSE_ID is empty)", configPath)
}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1 +1,12 @@
Env.SERVERLESS = "no"

# The pipeline yaml omits "catalog:" when default_catalog resolves to "" or
# "hive_metastore" (helper reads metastore.DefaultCatalogName). Without an
# explicit catalog, DLT falls back to (disabled) hive_metastore. Skip classic
# combinations on UC envs where this misfires; the serverless variant is
# unaffected because it hardcodes "catalog: main".
#
# Known UC API inconsistency: on our test workspaces, metastore.DefaultCatalogName
# is "hive_metastore" even though no such catalog exists. Drop this skip once UC
# fixes that.
SkipOnUnityCatalog = true

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,4 +1,13 @@
Cloud = true
# The pipeline yaml omits "catalog:" when default_catalog resolves to "" or
# "hive_metastore" (helper reads metastore.DefaultCatalogName). Without an
# explicit catalog, DLT falls back to (disabled) hive_metastore. Skip on UC
# envs where this misfires.
#
# Known UC API inconsistency: on our test workspaces, metastore.DefaultCatalogName
# is "hive_metastore" even though no such catalog exists. Drop this skip once UC
# fixes that.
SkipOnUnityCatalog = true
Timeout = '1m'

Ignore = [
Expand Down
3 changes: 3 additions & 0 deletions acceptance/internal/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ type TestConfig struct {
// If true and Cloud=true, run this test only if unity catalog is available in the cloud environment
RequiresUnityCatalog *bool

// If true and Cloud=true, skip this test when Unity Catalog is available in the cloud environment
SkipOnUnityCatalog *bool

// If true and Cloud=true, run this test only if a default test cluster is available in the cloud environment
RequiresCluster *bool

Expand Down
1 change: 1 addition & 0 deletions acceptance/internal/materialized_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ func GenerateMaterializedConfig(config *TestConfig) string {
writeBool(&buf, "Cloud", config.Cloud)
writeBool(&buf, "CloudSlow", config.CloudSlow)
writeBool(&buf, "RequiresUnityCatalog", config.RequiresUnityCatalog)
writeBool(&buf, "SkipOnUnityCatalog", config.SkipOnUnityCatalog)
writeBool(&buf, "RequiresCluster", config.RequiresCluster)
writeBool(&buf, "RequiresWarehouse", config.RequiresWarehouse)
writeBool(&buf, "RunsOnDbr", config.RunsOnDbr)
Expand Down
Loading