Verify the FIPS module in released binaries - #6292
Open
ilyakuz-db wants to merge 1 commit into
Open
Conversation
ilyakuz-db
force-pushed
the
fips140-verify-release-artifacts
branch
from
August 17, 2026 14:18
5d38296 to
7cda2f2
Compare
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
ilyakuz-db
force-pushed
the
fips140-verify-release-artifacts
branch
from
August 17, 2026 14:41
7cda2f2 to
cea4e42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds a
Verify FIPS module in binariesstep to the release build. It reads each binary's build info and fails the release if any is missing the validated cryptographic module or does not default to FIPS mode.Runs after signing, so it checks the artifacts that actually get published.
Merge after #6262, which is what sets
GOFIPS140in.goreleaser.yaml.Why
#6262 makes releases FIPS builds, but nothing checks that the variable reached the artifacts. If it were dropped, the release would silently ship non-FIPS binaries, and the test suite could not catch it because tests build their own binary rather than inspecting
dist/.go version -mreads build info rather than the symbol table, so it works on stripped binaries and on the darwin/windows builds from the linux release runner.Tests
Ran the script against real linux, windows and darwin binaries built with
GOFIPS140=v1.0.0 -s -w -trimpath— all verified from a linux host. Swapping in a non-FIPS build fails with the offending path named, and the empty-dist/guard fires so the loop cannot pass vacuously.This PR was written by Claude Code.