[E2E] Add timestamp to unique name - #2119
Conversation
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
🤖 Integration tests ✅ all 35 test jobs passed for |
rugpanov
left a comment
There was a problem hiding this comment.
LGTM — reviewed the change to getUniqueResourceName. Name-length and charset constraints are fine (worst case well under the 4096-byte job-name limit), collision resistance is unchanged/improved, and no existing test parses the name format, so this is backward-compatible.
One non-blocking suggestion: the vscode_integration_test_<ms>_<uuid> format is now effectively a contract consumed by the external cleanup job. A short comment pointing at that job (and, ideally, a tiny test pinning the format) would guard against a future refactor silently breaking cleanup. Legacy UUID-only directories created before this merge won't carry a parseable timestamp, so the cleanup job will need to handle those separately.
|
Review suggestions (non-blocking) — no blocking issues found across the review.
|
Changes
Add a timestamp to the unique name given to E2E directories. This allows a cleanup job to run and delete directories older than a given threshold
Tests
None