GH Actions Readiness#12
Open
MaximHammer wants to merge 10 commits into
Open
Conversation
adefabian
reviewed
May 14, 2026
| id-token: write | ||
| contents: read | ||
| pull-requests: write | ||
| id-token: write |
Collaborator
There was a problem hiding this comment.
I think this id-token: write has to be moved to the test job
https://docs.google.com/document/d/1J50oKQxG9WhGXWEl5zlbCq5pf9AGh57yDhZh9nxCQC0/edit?tab=t.0
similar to this
jobs:
integration:
permissions:
# Access to the integration testing infrastructure.
id-token: write
# Write test results to the PR.
pull-requests: write
adefabian
approved these changes
May 14, 2026
Collaborator
adefabian
left a comment
adefabian
left a comment
There was a problem hiding this comment.
Other than the id-token stuff looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow ups: