Skip to content

Automated Integration Test Goldens Update from CI #6000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
datacommons-robot-author wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Automated Integration Test Goldens Update from CI #6000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...n_tests/test_data/detection_api_bio/whattypesofgenesarefgfr1,apoe,andache/debug_info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
0.38543,
0.38534,
0.38184,
0.37971
0.3797
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While reducing the precision of this score is a good step, the scores in this list now have inconsistent precision. To improve test stability and reduce noise from minor model fluctuations, it's recommended to enforce a consistent, lower precision for all floating-point scores in test data.

For consistency, consider rounding all scores in this array to 4 decimal places. For example:

[
  ...,
  0.3854,
  0.3853,
  0.3818,
  0.3797
]
References
  1. Round floating-point scores in test data to a consistent, lower precision. This makes tests more robust against insignificant model output variations and reduces review noise.

],
"MultiSV": {},
"Query": "what types of genes are and",
Expand Down
2 changes: 1 addition & 1 deletion ...ar/howarefactorslikeobesity,bloodpressureandasthmaimpactedbyclimatechange/debug_info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
0.63385,
0.63227,
0.63222,
0.63049,
0.6305,
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change rounds the score to 4 decimal places, which is good. However, other scores in this array still have varying precision, leading to inconsistency. To make these golden file tests more robust against minor model output variations, all floating-point scores should be rounded to a consistent precision.

For example, all scores in this list could be rounded to 4 decimal places:

[
  ...,
  0.6339,
  0.6323,
  0.6322,
  0.6305,
  0.6303,
  0.6298,
  0.6296
]
References
  1. Round floating-point scores in test data to a consistent, lower precision. This makes tests more robust against insignificant model output variations and reduces review noise.

0.6303,
0.62984,
0.62957
Expand Down
Loading