fix: to ensure Docker Compose starts without errors, you need to add …#486
Open
AntonyCheng wants to merge 1 commit intodataelement:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Register the
Notificationmodel inbackend/alembic/env.pyso that Alembic detects thenotificationstable during migrations.Problem
When running
docker compose up, the application fails to start with an error indicating thenotificationstable cannot be found. This happens because theNotificationmodel was not imported in the Alembic environment file, so SQLAlchemy'sBase.metadatanever registered it. As a result, Alembic is unaware of the table and cannot manage it through migrations.Solution
Add the
Notificationmodel import alongside the other model imports already present inbackend/alembic/env.py:This follows the same pattern used for all other models in the file (e.g.,
Agent,User,AuditLog, etc.) and ensuresBase.metadataincludes thenotificationstable.Test Plan
docker compose upand confirm the application starts without the missing table erroralembic revision --autogenerate -m "description"and verify thenotificationstable is correctly detected