完成前端开发优化#514
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ed552817f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # Overlay custom soul (rich Morty/Meeseeks persona over the generic template) | ||
| (agent_dir / "soul.md").write_text(soul_content.strip() + "\n", encoding="utf-8") |
There was a problem hiding this comment.
Move default-agent personalization out of fallback-only block
This write is now nested under the else branch that runs only when template_dir is missing, so in the normal path (template exists) Morty/Meeseeks never get their custom soul.md content or state stamping. That changes seeded agents to generic template identities and leaves state.json placeholders, which breaks the intended default personas and agent metadata for standard deployments.
Useful? React with 👍 / 👎.
| existing_agents = await db.execute( | ||
| select(Agent).where(Agent.name.in_(["Morty", "Meeseeks"])).limit(2) | ||
| ) |
There was a problem hiding this comment.
Keep seed idempotency independent of mutable agent names
The new guard checks for Morty/Meeseeks by name even when the .seeded marker exists; if an operator renames either default agent, startup will treat them as missing and re-seed duplicates. This regresses the previous marker-based idempotency contract (also stated in the docstring) and can create extra default agents after normal admin edits.
Useful? React with 👍 / 👎.
| target: 'http://localhost:8001', | ||
| changeOrigin: true, | ||
| }, | ||
| '/ws': { | ||
| target: 'ws://localhost:8008', | ||
| target: 'ws://localhost:8001', |
There was a problem hiding this comment.
Restore Vite proxy targets to the active backend port
Changing the dev proxy target from localhost:8008 to localhost:8001 disconnects the frontend from the backend used by this repo’s startup flow (restart.sh/README use port 8008). In local development, /api and /ws requests will fail unless a separate service is running on 8001, so core app interactions break by default.
Useful? React with 👍 / 👎.
标题: 完成前端开发优化
描述:
完成前端项目的开发和优化工作,包括以下改进:
✅ 完成的功能
🔧 技术变更
📋 测试验证