Release v2.9.0: bump version and rebuild mex binaries#104
Draft
dimitri-yatsenko wants to merge 3 commits into
Draft
Release v2.9.0: bump version and rebuild mex binaries#104dimitri-yatsenko wants to merge 3 commits into
dimitri-yatsenko wants to merge 3 commits into
Conversation
ubuntu-latest runners dropped docker-compose v1; the integration workflow now invokes the v2 'docker compose' subcommand. Bumps actions/checkout to v4 for the same hygiene reason.
The integration workflow depends on raphaelguzman/matlab Docker images, an org-level MATLAB license, and a matrix pinned to R2018b/R2019a + MySQL 5.6-8.0.18 — a stack that has bit-rotted and doesn't cover the platforms users actually run on (Apple Silicon, MySQL 8.4 LTS). It now runs only via workflow_dispatch. In its place, a lightweight smoke check validates what we can verify without MATLAB: all four distribution/<mexext>/mym.<mexext> binaries are present and non-empty, src/mym.h exposes parseable version constants, and mktbx.m exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the embedded version constant in
src/mym.hto 2.9.0 in preparation for a v2.9.0 release that closes #103.Background
The latest published release is v2.8.5 (2022-03-09). Since then, master has gained:
distribution/mexmaca64/andmex_compilation/compile_mexmaca64.mvia Add native support for Apple silicon Macs. #101 (@cnuahs)ghtb.install('datajoint/mym')resolves to the latest GitHub Release'smym.mltbxasset and does NOT install from master, so users like @tabedzki (#103, #99) currently get the 2022 build with no Apple Silicon coverage. A tagged release is needed.Why this PR exists
mktbx.mreads the toolbox version frommym('version')returned by the compiled mex. The committed binaries on master were all compiled withMYM_VERSION_BUGFIX=5and report 2.8.5 at runtime. Without a re-stamp, the.mltbxpublished for v2.9.0 would carry 2.8.5 metadata internally, and MATLAB's Add-On Manager would likely refuse to upgrade existing 2.8.5 installs.This PR bumps the version constant only. The binaries need to be rebuilt against the bumped header before the release is cut.
Ask of @cnuahs
You built the 2024 binaries — would you be able to rebuild
mexa64,mexw64, andmexmaca64from this branch usingmex_compilation/compile_linux.m,compile_windows.m, andcompile_mexmaca64.m, and push the updated binaries torelease/v2.9.0?mexmaci64will ship unchanged (legacy Intel-Mac path; Apple deprecated Intel Macs in MATLAB R2024b+, so it's reasonable to leave the 2022 build in place for this stewardship release).Once the rebuilt binaries land, I'll run
mktbxto producemym.mltbx, merge this PR, tag v2.9.0, and create the GitHub Release.Closes / addresses