Ship no namespace with the fabric identity overlay - #14
Merged
Conversation
ecv
previously approved these changes
Aug 27, 2026
Contributor
|
commenting on an absence of code is wild |
The consumer names where this runs, as it does for every other component it deploys. Shipping a namespace made two owners for that name, and the one consumer of this overlay dropped it again with a patch that broke on the name changing underneath it. Key changes: - Remove the namespace from the fabric identity overlay
scotwells
force-pushed
the
fix/drop-fabric-identity-namespace
branch
from
August 27, 2026 15:03
378b06b to
b054bfc
Compare
ecv
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The consumer of this overlay names where the component runs, as it does for every other component it deploys. Shipping a namespace made two owners for that name.
It also broke the deployment. The consumer dropped the bundled namespace with a patch, and the name changes before that patch is applied, so the build failed and nothing was deployed.
Once a bundle carrying this publishes, that patch can go, which is datum-cloud/infra#4231.