Publish the bound NetworkInterface on Instance status - #245
Merged
Conversation
An infrastructure provider needs the interface an instance ended up with. Without a published reference it has to rebuild compute's private claim name to find it, which is a copy of an internal convention in another repo. The claim already carries the reference, so this is a passthrough. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
scotwells
marked this pull request as ready for review
August 20, 2026 23:51
This was referenced Aug 20, 2026
Merged
privateip
approved these changes
Aug 21, 2026
scotwells
added a commit
to datum-cloud/cloud
that referenced
this pull request
Aug 21, 2026
datum-cloud/compute#245 has merged, so networkInterfaceRef is on main and the branch pin this carried is no longer needed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
scotwells
added a commit
to datum-cloud/cloud
that referenced
this pull request
Aug 21, 2026
datum-cloud/compute#245 has merged, so networkInterfaceRef is on main and the branch pin this carried is no longer needed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Instance.status.networkInterfaces[].networkInterfaceRef: theNetworkInterfacebound to that entry, in the instance's namespace.Something configuring the attachment needs the interface the instance ended up with. Without a published reference it has to reconstruct compute's private
networkInterfaceClaimNameto find the claim first — the Unikraft provider currently carries a verbatim copy of that function, sha256 truncate-and-hash fallback included, in another repo. A private naming convention duplicated across repos breaks silently the day it changes.The reader is now the VPC controller's Pod admission webhook rather than the infrastructure provider: the webhook resolves a Pod to its Instance, follows this reference to each interface, and injects whatever the delivery mechanism requires. Same reason for the field, one fewer component that has to know how compute names things — and with the provider out of that path entirely, the duplicated function is deleted rather than merely unused.
The change is a passthrough:
reconcileNetworkInterfaceStatusalready reads the claim to publish addresses and conditions, and the claim already carriesstatus.networkInterfaceRef.The field reuses NSO's existing
LocalNetworkInterfaceRefrather than declaring a compute-local struct, so anything following the chain from Instance to interface handles one shape rather than two.Not in this change: the capability class that decides how a guest consumes the NIC. That is a product API decision tracked separately.
make lintclean; full unit suite (non-e2e, with envtest) green.docs/apiis generated and already drifted on main, so it is left untouched to keep the diff to the change itself.Related
🤖 Generated with Claude Code