Make the VRF sidecar's NET_ADMIN effective - #414
Merged
Conversation
Kubernetes does not set ambient capabilities, so an added capability only enters the effective set for uid 0. The sidecar image is distroless:nonroot, so NET_ADMIN was declared and inert, and creating the VRF device failed with EPERM. Match the staging channel, which carries the same fix, so dev and e2e do not diverge from what the edge runs. Key changes: - Run the sidecar as uid 0 in the dev and e2e downstream configs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VRF sidecar declares NET_ADMIN and cannot use it. Kubernetes does not set ambient capabilities, so an added capability only enters the effective set for uid 0, and the image is
distroless:nonroot.Creating the VRF device fails with EPERM. The container starts and passes its checks first, so this reads as a healthy sidecar.
Runs it as uid 0 holding NET_ADMIN alone, matching the staging channel so dev and e2e do not drift from what the edge runs.
Paired with datum-cloud/infra#4279.
Related: #411