More flags for metrics, to allow easier skipping#13
Open
karenetheridge wants to merge 3 commits intodaxim:masterfrom
karenetheridge:topic/more_flags_on_metrics
Open
More flags for metrics, to allow easier skipping#13karenetheridge wants to merge 3 commits intodaxim:masterfrom karenetheridge:topic/more_flags_on_metrics
karenetheridge wants to merge 3 commits intodaxim:masterfrom
karenetheridge:topic/more_flags_on_metrics
Conversation
…e a dist.tar.gz to work with
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test::Kwalitee 1.09 now tests all the 'standard' (not extra, experimental) that Module::CPANTS::Analyse makes available, except for these tests: no_generated_files, extractable, extracts_nicely, has_proper_version, has_version, manifest_matches_dist.
The first of these (no_generated_files) cannot be run after a 'make' or './Build', as we will get false positives from the files that were generated.
The rest all need a dist.tar.gz to be present, to compare against.
It would be easier to be able to skip these tests by using flags, rather than having to hardcode the names themselves (so as to give you more flexibility in the future to add more metrics).