feat: add a setting to disable git commit attribution - #344
Merged
parsakhaz merged 1 commit intoJul 21, 2026
Merged
Conversation
Adds a global gitAttributionEnabled setting (default true) that gates the GIT_COMMITTER_NAME/EMAIL injection Pane adds to every commit made through its terminals, CLI panels, and internal git operations. Previously "Include Pane footer in commits" was the only related toggle, but it only controlled the Co-Authored-By trailer, not the committer identity — so commits always showed as "committed by runpane" on GitHub with no way to opt out. - New getGitAttributionEnv() helper in attribution.ts, gating the existing GIT_ATTRIBUTION_ENV constant behind the setting - Wired into all 9 injection sites (terminal panels, terminal sessions, run commands, CLI panels, project init, worktree operations, editor commits) - New "Attribute commits to Pane" toggle in Settings > Worktrees & Git Fixes dcouple#343
parsakhaz
approved these changes
Jul 21, 2026
parsakhaz
left a comment
Member
There was a problem hiding this comment.
Approved based on a read-only implementation review against issue #343.
Evidence checked:
- The new
gitAttributionEnabledflag is default-on and gates the PaneGIT_COMMITTER_NAME/GIT_COMMITTER_EMAILinjection throughgetGitAttributionEnv(). - All attribution injection paths from the issue are covered: terminal panels, legacy terminal sessions, run commands, Claude/Codex CLI panels, project initialization, worktree internal commits, and editor commit/retry paths.
- Config typing and persistence are wired on both main/frontend sides, and the setting is reachable in Settings > Worktrees & Git.
- Node 22 checks passed locally on the PR head:
pnpm typecheck: PASSpnpm lint: PASS, 0 errors; existing warnings only- Focused tests:
pnpm --filter main exec vitest run src/utils/attribution.test.ts src/services/terminalPanelManager.test.ts: PASS, 16 tests
Non-blocking nuance: terminal-panel WSL startup still lists GIT_COMMITTER_NAME and GIT_COMMITTER_EMAIL in WSLENV even when attribution is disabled. Since the gated env no longer sets those variables, this should be harmless in normal use, but it would be reasonable future hardening to omit those names from WSLENV when attribution is disabled.
Recommendation: approve and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gitAttributionEnabledsetting (defaulttrue) that gates theGIT_COMMITTER_NAME/GIT_COMMITTER_EMAILinjection Pane adds to every commit made through its terminals, CLI panels, and internal git operationsCo-Authored-Bytrailer — it never touched the committer identity, so commits always showed as "committed by runpane" on GitHub with no way to opt outgetGitAttributionEnv()helper inattribution.tscentralizes the default-true gating logic, wired into all 9 injection sites (terminal panels, terminal sessions, run commands, CLI panels, project init, worktree operations ×3, editor commits ×2)Fixes #343
Test plan
pnpm typecheckclean across all workspacespnpm lint— 0 errors (pre-existing warnings only, none in touched files)pnpm --filter main test— newattribution.test.tsunit tests pass; updatedterminalPanelManager.test.tsmock; full suite green aside from 3 pre-existing native-module ABI failures unrelated to this changePANE_DIR, throwaway git repo): toggled setting off → new terminal panel commit shows the user's own git identity as committer; toggled back on → new terminal panel commit showsPane <runpane@users.noreply.github.com>again