chore: cleanup some old unused code#7856
Merged
Merged
Conversation
yanthomasdev
approved these changes
Jun 12, 2026
yanthomasdev
left a comment
Contributor
There was a problem hiding this comment.
Amazing work, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spent a little bit of time investigating superfluous stuff in the repo using Knip. There’s quite a lot of potential cleanup work, but this PR sticks to some low hanging fruit (also to not make the PR too big to review).
new URL()so theurlnpm package is no longer neededThere’s more work where this is coming from, but next step would be removing unused exports etc. from code, which is a bit more delicate, so will save that for future PRs.
Test plan
Existing builds and tests should pass
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)