[deckhouse-cli] Revert "Bump stronghold to v1.18.6" and guard CI - #433
Merged
Conversation
This reverts commit 46e60e2. The bump switched the trdl build image to container-factory builder/golang-alt, which cannot work as a trdl builder: trdl requires a root image (its generated Dockerfile runs `mkdir -p /result` before any commands), while the new image runs as user 64535:64535 and is ALT-based, so the Debian-specific install commands in trdl.yaml would fail as well. As a result the v0.33.5 trdl release failed and retried for 6 hours until cancelled. Revert to unblock releases. The stronghold v1.18.6 + GOST toolchain work should be re-landed together with a trdl-compatible builder image. Conflict resolution: golang.org/x/sync stays a direct dependency (added by #431 after the bump). Signed-off-by: Roman Berezkin <roman.berezkin@flant.com>
Reproduce the trdl server release build in CI: generate the same Dockerfile the server generates from trdl.yaml and run it with the same secret ids. Catches a broken release pipeline in the PR that breaks it instead of on the next release tag. Runs on PRs touching trdl.yaml, go.mod/go.sum or Taskfile.yml, weekly by cron, and manually via workflow_dispatch. Signed-off-by: Roman Berezkin <roman.berezkin@flant.com>
ldmonster
approved these changes
Aug 4, 2026
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Releases are blocked: after #415 the trdl server cannot build d8. This PR reverts #415 and adds a CI check that runs the same build on risky PRs, so a broken release pipeline shows up in the PR, not on a tag.
Problem
#415 switched the build image in
trdl.yamltobuilder/golang-alt. The trdl server cannot use it:mkdir -p /resultin the filesystem root, and the image runs as user64535:64535trdl.yamlare written for Debian (apt-getpackage names,dpkg -L)The v0.33.5 release failed on
mkdir -p /result: Permission deniedand retried for 6 hours: https://github.com/deckhouse/deckhouse-cli/actions/runs/30816427104GitHub CI stayed green: it never runs this image, it only unpacks
/usr/local/gofrom it.v0.33.5 ended up as a GitHub release that cannot reach the trdl channels.
Fix
Revert #415:
trdl.yamlbuilds on the root Debian image againgostbuild tagd8 stronghold operator raft snapshot inspectcommand goes away with itConflict note:
golang.org/x/syncstays a direct dependency (added later by #431).The stronghold v1.18.6 + GOST work should come back with a trdl-compatible builder image: root user, build deps preinstalled or installed with ALT package names.
Protection: trdl build check in CI
The failure stayed hidden until a tag because nothing runs the trdl build before it. The new check closes this gap.
What it does:
.github/scripts/trdl-build-check.shgenerates the same Dockerfile the trdl server generates fromtrdl.yamldocker buildwith the same secret ids on a fake tag/resultSecrets it uses (both already exist in CI, nothing new to add):
SOURCE_REPO_SSH_KEY- SSH key to read the private repos, passed to the build as thestronghold-sshsecretDECKHOUSE_PRIVATE_REPO- private repo hostname, passed as thedeckhouse-private-reposecretWhen it runs:
trdl.yaml,go.mod,go.sumorTaskfile.ymlworkflow_dispatchGreen check means the next tag will build on the trdl server. A change like #415 now fails in its own PR, in the first minute.
Tests
CGO_ENABLED=0, release tag set withoutgost)