test: type-check test/components/embedders and add it to mypy config#11859
Open
omborda2002 wants to merge 1 commit into
Open
test: type-check test/components/embedders and add it to mypy config#11859omborda2002 wants to merge 1 commit into
omborda2002 wants to merge 1 commit into
Conversation
|
@omborda2002 is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Next piece-meal step for #10396, this one covers
test/components/embedders/.test/components/embedders/to thetest:typesmypy paths inpyproject.tomlUsageobject intest_openai_text_embedder.pyinstead of passing a raw dictempty_list_inputvariables aslist[Document]assert embedder.embedding_backend is not Noneafterwarm_up()in the sentence transformers tests that set.model.max_seq_length, since the attribute is Optional before warm up# type: ignore[arg-type]/# type: ignore[call-arg]only where a test passes a wrong type on purpose to check the raised TypeErrorHow did you test it?
hatch run test:typespasses with the new folder included (no issues in 394 source files)hatch run test:unit test/components/embedders/passes (163 tests)hatch run fmtis cleanNotes for the reviewer
Tests and CI config only, so I did not add a release note file (same as #11728).
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.