Skip to content

test: remove stale TODO and disambiguate PEP 585 param ids in type-utils test#11866

Open
RajanChavada wants to merge 1 commit into
deepset-ai:mainfrom
RajanChavada:test/remove-stale-pep585-todo
Open

test: remove stale TODO and disambiguate PEP 585 param ids in type-utils test#11866
RajanChavada wants to merge 1 commit into
deepset-ai:mainfrom
RajanChavada:test/remove-stale-pep585-todo

Conversation

@RajanChavada

Copy link
Copy Markdown

Related Issues

None — small test-suite cleanup.

Proposed Changes:

test/core/test_type_utils.pycarried a# TODO These tests are failing comment above four PEP 585 lowercase-generic cases (list[int]vslist, etc.) that all pass today. The comment is stale, and the four params reused the same pytest id=strings as theirtyping.List/Dict/...counterparts, so pytest silently suffixed them0/1, making output confusing. This removes the stale TODO and gives the PEP 585 params distinct -pep585` ids. Tests-only change.

How did you test it?

hatch run test:unit test/core/test_type_utils.py -k "bare_container" → 17 passed.

Notes for the reviewer

This change was prepared with Claude Code and reviewed by the author.

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@RajanChavada RajanChavada requested a review from a team as a code owner July 3, 2026 19:24
@RajanChavada RajanChavada requested review from sjrl and removed request for a team July 3, 2026 19:24
@vercel

vercel Bot commented Jul 3, 2026

Copy link
Copy Markdown

@RajanChavada is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant

CLAassistant commented Jul 3, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants