chore: removing APIs and deprecation warnings: 0.30.x here we come #3962
+2,038
−5,589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
binding/python
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3962 +/- ##
===========================================
+ Coverage 26.22% 71.47% +45.24%
===========================================
Files 124 152 +28
Lines 19886 39157 +19271
Branches 19886 39157 +19271
===========================================
+ Hits 5216 27988 +22772
+ Misses 14300 9889 -4411
- Partials 370 1280 +910 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rtyler
force-pushed
the
next-version-three-zero
branch
2 times, most recently
from
8c9e6e6 to
b5e4cd0
Compare
roeap
reviewed
Dec 2, 2025
Collaborator
roeap
left a comment
roeap
left a comment
There was a problem hiding this comment.
first pass over pushed changes. Just one question.
we need some more clippy, but awesome to get rid of some of this.
| &self, | ||
| limit: Option<usize>, | ||
| ) -> Result<impl Iterator<Item = CommitInfo>, DeltaTableError> { | ||
| ) -> Result<impl Iterator<Item = CommitInfo> + use<>, DeltaTableError> { |
Member
Author
There was a problem hiding this comment.
@roeap there's a change in Rust 2024 edition to how strict it considers impl Trait lifetimes.
Collaborator
There was a problem hiding this comment.
It's for defining the captured lifetimes of traits. In this case if you have an associated lifetime here (not '_) use<> captures that. It's just more well defined on what lifetimes are involved in the return type vs. other borrows in the call.
rtyler
force-pushed
the
next-version-three-zero
branch
2 times, most recently
from
059834e to
659b756
Compare
Contributor
|
Cool! If you need my help I can rerun somthing like this PR to remove the other clippy warnings. |
rtyler
force-pushed
the
next-version-three-zero
branch
from
659b756 to
6740f2f
Compare
github-actions
bot
added
the
documentation
rtyler
force-pushed
the
next-version-three-zero
branch
from
6740f2f to
32502f7
Compare
Signed-off-by: R. Tyler Croy <[email protected]>
Signed-off-by: R. Tyler Croy <[email protected]>
When using LogStoreConfig it is possible to pass a Url which does allow for safe `join()` operations inside of delta-kernel-rs. This change ensures that we always have a trailing slash before passing things off into kernel Signed-off-by: R. Tyler Croy <[email protected]>
Signed-off-by: R. Tyler Croy <[email protected]>
Signed-off-by: R. Tyler Croy <[email protected]>
This is almost entirely formatting changes, which is a _wee_ bit annoying. There were no practical code changes required however. Signed-off-by: R. Tyler Croy <[email protected]>
Signed-off-by: R. Tyler Croy <[email protected]>
Signed-off-by: R. Tyler Croy <[email protected]>
Every trailing slashes cause all sorts of subtle equivalency confusion when we do things with a Url. It's better for us to normalize everything to always have a trailing slash which makes it easier to join with, and do other things. Signed-off-by: R. Tyler Croy <[email protected]>
In this commit I am intentionally introducing the convention in our Rust
APIs:
* anything named `uri` is expected to take a `AsRef<str>` type which
is expected to turn into a `Url`
* anything named `url` is expected to take a `Url` type.
As such I have renamed a number of our APIs which previously had been
converted to use `Url` but were referring to them as `uri`
Signed-off-by: R. Tyler Croy <[email protected]>
This is a hilariously invasive change insofar that we have URL-like strings leaking out all over the place in our codebase. This channge attempts to wrangle as much of that together as possible and has test API changes which support the preceeding commit where _uri functions become _url Signed-off-by: R. Tyler Croy <[email protected]>
rtyler
force-pushed
the
next-version-three-zero
branch
from
32502f7 to
07e5913
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💣 💥