-
Notifications
You must be signed in to change notification settings - Fork 555
feat: support full path URIs #3963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Corwin Joy <[email protected]>
|
This is a draft PR for discussion.
Overall I think this gives a good picture of what would be needed for full path support. |
|
@hntd187 @adamreeve tagging due to related discussion on shallow clones. |
| // TODO. May be a security risk to allow absolute paths outside the bucket/account. | ||
| // When need_bucket_root_store is true, the code registers a bucket-root object | ||
| // store that could access ANY object in the bucket, not just those in the | ||
| // table directory. This has similar security implications to the file-root store above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note. I have not added an environment variable to allow this like I did for filesystems. I'm not as sure this is necessary since object stores have more detailed bucket permissions. But, I guess it could still be a problem for delta-rs running as a superuser with malicious delta tables.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3963 +/- ##
==========================================
- Coverage 26.28% 26.05% -0.23%
==========================================
Files 124 124
Lines 19839 20058 +219
Branches 19839 20058 +219
==========================================
+ Hits 5214 5226 +12
- Misses 14254 14460 +206
- Partials 371 372 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| .add(b'}') | ||
| .add(b'%') | ||
| // NOTE: '%' is NOT included here to avoid double-encoding. | ||
| // Paths already contain valid percent-encoded characters from partition values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this may represent an existing bug in the coding.
Signed-off-by: Corwin Joy <[email protected]>
Description
Add support for absolute file paths and full path URIs to hold parquet file names in the delta logstore.
Related Issue(s)
Closes #865
Documentation
These kind of paths occur when creating shallow clones via Java. In addition there may be other cases where we wish to specify the files as full URIs.