moved unnecessary copy of StringOrInit up into the test layer#95
Merged
valenting merged 1 commit intodenoland:mainfrom Feb 11, 2026
Merged
moved unnecessary copy of StringOrInit up into the test layer#95valenting merged 1 commit intodenoland:mainfrom
valenting merged 1 commit intodenoland:mainfrom
Conversation
edgul
force-pushed
the
f-cow
branch
3 times, most recently
from
d5cd67d to
c95cb97
Compare
Contributor
Author
|
I can't seem to change the title of the PR to this: |
…ling quirks::process_match_input.
Collaborator
|
This looks good to me. However this is a breaking change, since we modify some public enums and traits, so it will probably need a version bump. @crowlKats @lucacasonato let me know if you have any comments. If not, I'll land this later this week. |
Member
|
no comments from us |
valenting
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make StringOrInit use COW for string variant to avoid a copy when calling
quirks::process_match_input