Skip to content

Conversation

@alexchan-va
Copy link
Contributor

Keep your PR as a Draft until it's ready for Platform review. A PR is ready for Platform review when it has a teammate approval and tests, linting, and settings checks pass CI. See these tips on how to avoid common delays in getting your PR merged.

Summary

  • This work is behind a feature toggle (flipper): YES/NO no
  • (Summarize the changes that have been made to the platform) Changed formatting of fields written to 1919 pdf, specifically:
  • Missing city, state, zip in address
    Need Name, Title for fields that show names and titles (titles are missing presently)
    Where we have "VA" or "SAA" shown - show "VA employee" or "SAA employee"
    Format dates as preferred on PDF - MM/DD/YYYY not yyyy-mm-dd
    Uppercase certifying official under certification title
  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution?) To change formatting based on what was found
  • (Which team do you work for, does your team own the maintenance of this component?) VEBT
  • (If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

  • Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira https://jira.devops.va.gov/browse/VEBT-3999
  • Link to previous change of the code/bug (if applicable)
  • Link to epic if not included in ticket

Testing done

  • [ x] New code is covered by unit tests
  • Describe what the old behavior was prior to the change It was not formatted correctly to the requirements
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing Get the 1919 PDF and verify the fieldsa re formatted correctly
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional
image_720

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas) n/a

Acceptance criteria

  • [x ] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • [x ] No error nor warning in the console.
  • [x ] Events are being sent to the appropriate logging solution

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@alexchan-va alexchan-va marked this pull request as ready for review December 5, 2025 16:50
@alexchan-va alexchan-va requested review from a team as code owners December 5, 2025 16:50
@alexchan-va alexchan-va merged commit b0a84f6 into master Dec 8, 2025
41 of 42 checks passed
@alexchan-va alexchan-va deleted the VEBT-3999 branch December 8, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants