Skip to content

Update 2025 net worth value to 2026 value #25449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
davidbecker6081 wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Update 2025 net worth value to 2026 value #25449

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a5353e8
Update 2025 net worth value to 2026 value
davidbecker6081 Dec 5, 2025
4937846
Update codeowners
davidbecker6081 Dec 5, 2025
f767e2b
WIP - pass current user to pdf filler for 686c
davidbecker6081 Dec 9, 2025
2d6c9fc
Revert changes to pass user to pdf filler
davidbecker6081 Dec 10, 2025
c716c42
Update household income wording based on pension net worth flipper fo…
davidbecker6081 Dec 10, 2025
85d7cf2
Do not show net worth/income questions if they do not exist and FF is on
davidbecker6081 Dec 10, 2025
9c94365
Merge branch 'master' of https://github.com/department-of-veterans-af…
davidbecker6081 Dec 11, 2025
53ad4d4
WIP - fix pdf fill form specs for dependents benefits
davidbecker6081 Dec 11, 2025
fe8518a
Fix pdf overflow issues including specs
davidbecker6081 Dec 11, 2025
d787398
rubocop
davidbecker6081 Dec 11, 2025
eadfe55
Safenav if key exists checks for net worth/pension pdf fillers
davidbecker6081 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ app/models/form_profiles/va_0976.rb @department-of-veterans-affairs/govcio-vfep-
app/models/form_profiles/va_2122.rb @department-of-veterans-affairs/accredited-representative-crew @department-of-veterans-affairs/backend-review-group
app/models/form_profiles/va_2122a.rb @department-of-veterans-affairs/accredited-representative-crew @department-of-veterans-affairs/backend-review-group
app/models/form_profiles/va_212680.rb @department-of-veterans-affairs/benefits-optimization-aquia @department-of-veterans-affairs/backend-review-group
app/models/form_profiles/va_686c674v2.rb @department-of-veterans-affairs/benefits-dependents-management @department-of-veterans-affairs/backend-review-group
app/models/form_submission_attempt.rb @department-of-veterans-affairs/platform-va-product-forms @department-of-veterans-affairs/disability-benefits @department-of-veterans-affairs/backend-review-group
app/models/form_submission.rb @department-of-veterans-affairs/platform-va-product-forms @department-of-veterans-affairs/disability-benefits @department-of-veterans-affairs/backend-review-group
app/models/form1010_ezr_attachment.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/backend-review-group
Expand Down
4 changes: 2 additions & 2 deletions app/models/form_profiles/va_686c674v2.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,10 @@ def is_in_receipt_of_pension # rubocop:disable Naming/PredicatePrefix
end
end

# @return [Integer] the net worth limit for pension, default is 159240 as of 2025
# @return [Integer] the net worth limit for pension, default is 163,699 as of 2026
# Default will be cached in future enhancement
def net_worth_limit
awards_pension[:net_worth_limit] || 159240 # rubocop:disable Style/NumericLiterals
awards_pension[:net_worth_limit] || 163699 # rubocop:disable Style/NumericLiterals
end

# @return [Hash] the awards pension data from BID service or an empty hash if the request fails
Expand Down
4 changes: 2 additions & 2 deletions modules/dependents_benefits/app/models/dependents_benefits/form_profiles/va_686c674.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,10 @@ def is_in_receipt_of_pension # rubocop:disable Naming/PredicatePrefix
end
end

# @return [Integer] the net worth limit for pension, default is 159,240 as of 2025
# @return [Integer] the net worth limit for pension, default is 163,699 as of 2026
# Default will be cached in future enhancement
def net_worth_limit
awards_pension[:net_worth_limit] || 159_240
awards_pension[:net_worth_limit] || 163_699
end

# @return [Hash] the awards pension data from BID service or an empty hash if the request fails
Expand Down
2 changes: 1 addition & 1 deletion modules/dependents_benefits/spec/fixtures/form_profile/prefill.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def self.non_prefill_data
'veteranSsnLastFour' => '1863',
'veteranVaFileNumberLastFour' => '1863',
'isInReceiptOfPension' => -1,
'netWorthLimit' => 159_240
'netWorthLimit' => 163_699
}
end

Expand Down
6 changes: 3 additions & 3 deletions modules/dependents_benefits/spec/models/dependents_benefits/form_profiles/va_686c674_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ def expect_prefilled(form_id)
'veteranSsnLastFour' => '1863',
'veteranVaFileNumberLastFour' => '1863',
'isInReceiptOfPension' => -1,
'netWorthLimit' => 159240 # rubocop:disable Style/NumericLiterals
'netWorthLimit' => 163699 # rubocop:disable Style/NumericLiterals
},
'veteranInformation' => {
'fullName' => {
Expand Down Expand Up @@ -293,7 +293,7 @@ def expect_prefilled(form_id)
prefilled_data = described_class.for(form_id: '686C-674-V2', user:).prefill[:form_data]

expect(prefilled_data['nonPrefill']['isInReceiptOfPension']).to eq(-1)
expect(prefilled_data['nonPrefill']['netWorthLimit']).to eq(159_240)
expect(prefilled_data['nonPrefill']['netWorthLimit']).to eq(163_699)
end
end
end
Expand Down Expand Up @@ -444,7 +444,7 @@ def expect_prefilled(form_id)
prefilled_data = described_class.for(form_id: '686C-674-V2', user:).prefill[:form_data]

expect(prefilled_data['nonPrefill']['isInReceiptOfPension']).to eq(-1)
expect(prefilled_data['nonPrefill']['netWorthLimit']).to eq(159_240)
expect(prefilled_data['nonPrefill']['netWorthLimit']).to eq(163_699)
end
end
end
Expand Down
8 changes: 4 additions & 4 deletions spec/models/form_profile_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@
'veteranSsnLastFour' => '1863',
'veteranVaFileNumberLastFour' => '1863',
'isInReceiptOfPension' => -1,
'netWorthLimit' => 159240 # rubocop:disable Style/NumericLiterals
'netWorthLimit' => 163699 # rubocop:disable Style/NumericLiterals
},
'veteranInformation' => {
'fullName' => {
Expand Down Expand Up @@ -1672,7 +1672,7 @@ def expect_prefilled(form_id)
'veteranSsnLastFour' => '1863',
'veteranVaFileNumberLastFour' => '1863',
'isInReceiptOfPension' => -1,
'netWorthLimit' => 159240 # rubocop:disable Style/NumericLiterals
'netWorthLimit' => 163699 # rubocop:disable Style/NumericLiterals
},
'veteranInformation' => {
'fullName' => {
Expand Down Expand Up @@ -1770,7 +1770,7 @@ def expect_prefilled(form_id)
)

expect(prefilled_data['nonPrefill']['isInReceiptOfPension']).to eq(-1)
expect(prefilled_data['nonPrefill']['netWorthLimit']).to eq(159240) # rubocop:disable Style/NumericLiterals
expect(prefilled_data['nonPrefill']['netWorthLimit']).to eq(163699) # rubocop:disable Style/NumericLiterals
end
end
end
Expand Down Expand Up @@ -1966,7 +1966,7 @@ def expect_prefilled(form_id)
)

expect(prefilled_data['nonPrefill']['isInReceiptOfPension']).to eq(-1)
expect(prefilled_data['nonPrefill']['netWorthLimit']).to eq(159240) # rubocop:disable Style/NumericLiterals
expect(prefilled_data['nonPrefill']['netWorthLimit']).to eq(163699) # rubocop:disable Style/NumericLiterals
end
end
end
Expand Down
Loading