Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds scopes support to the authentication system by extending the Token interface and AuthenticationInfo to include a scopes field, along with adding a new VerifyOptions interface for JWT verification. The implementation includes utility functions for scope validation and retrieval.
- Adds
scopesfield to Token interface andVerifyOptionsinterface for JWT verification - Implements scope validation functions (
hasScopes,getMatchedScopes) with corresponding SDK methods - Updates JWT validation methods to accept optional verification options
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/types.ts | Adds scopes field to Token interface and defines new VerifyOptions interface |
| lib/index.ts | Updates JWT validation methods to accept VerifyOptions and adds scope validation methods to SDK |
| lib/helpers.ts | Implements utility functions for scope extraction and validation |
| lib/constants.ts | Defines the scopes claim name constant |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
|
@gaokevin1 please check this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes <link_to_github_issue>
Description
Added
scopesto the main AuthenticationInfo interface, so it's easier to check and get scopes in the token.You can use
claimsbut I think we should have a dedicated variable here. Will only apply to OIDC-compliant tokens that include scope claims.Must