feat: add selectedTenant to AccessKeyLoginOptions#768
Open
itamartal wants to merge 1 commit intodescope:mainfrom
Open
feat: add selectedTenant to AccessKeyLoginOptions#768itamartal wants to merge 1 commit intodescope:mainfrom
itamartal wants to merge 1 commit intodescope:mainfrom
Conversation
…ange Amp-Thread-ID: https://ampcode.com/threads/T-019c7af6-3c5a-709c-886e-e51681bc3d8a Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
AccessKeyLoginOptionsin the Python SDK is missing theselectedTenantfield, which is already supported by the Descope API and by other SDKs such as the Go SDK:Without this field, users who need to exchange an access key with a specific tenant context (to get the
dctclaim set in the resulting JWT) must bypass the SDK and call the/v1/auth/accesskey/exchangeREST API directly, manually constructing the request with theselectedTenantinloginOptions.Changes
descope/common.py— Addedselected_tenantparameter toAccessKeyLoginOptions, serialized asselectedTenantto match the API contract.descope/auth.py— Updatedexchange_access_keyto filter outNonevalues from theloginOptionsdict, matching the Go SDK'somitemptybehavior. This ensuresselectedTenantis only included in the request when explicitly provided.tests/test_auth.py— Added test case verifying thatselected_tenantis correctly serialized asselectedTenantin the API request body.Usage