fix: backup job handles workspace with no storage #1573
+129
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function will be used across both backup and restore features and should be accessed multiple places. Signed-off-by: Ales Raszka <[email protected]>
Workspace with no storage failed in the backup process. This commit fixes it by checking if the volumes are present and skip the job if no pvc is available. fixes: 1555 Signed-off-by: Ales Raszka <[email protected]>
Allda
requested review from
akurinnoy,
dkwon17,
ibuziuk and
rohanKanojia
as code owners
dkwon17
approved these changes
Jan 14, 2026
tolusha
approved these changes
Jan 15, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Allda, dkwon17, tolusha The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/test v14-devworkspace-operator-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Skip backup if the workspace is missing volumes
Workspace with no storage failed in the backup process. This commit
fixes it by checking if the volumes are present and skips the job if no
pvc is available.
fixes: 1555
What issues does this PR fix or reference?
#1555
Is it tested? How?
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che