feat: add forMe query param to DELETE /messages for local-only deletion#2023
Open
zaghloul404 wants to merge 1 commit intodevlikeapro:corefrom
Open
feat: add forMe query param to DELETE /messages for local-only deletion#2023zaghloul404 wants to merge 1 commit intodevlikeapro:corefrom
zaghloul404 wants to merge 1 commit intodevlikeapro:corefrom
Conversation
Adds a `forMe` boolean query parameter to the delete message API. When forMe=true, WEBJS calls message.delete(false) for local-only deletion instead of message.delete(true) which revokes for everyone. This enables "delete for me" on sent messages without leaving a "You deleted this message" trace on the recipient's phone. Made-with: Cursor
Contributor
|
Let's see how many Comment with "+1" if you need it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2022
Summary
Adds a
forMeboolean query parameter toDELETE /api/{session}/chats/{chatId}/messages/{messageId}.When
forMe=true, the WEBJS engine callsmessage.delete(false)instead ofmessage.delete(true), triggering a local-only deletion (sendDeleteMsgs) instead of a revoke (sendRevokeMsgs). This enables true "delete for me" behavior for sent messages.Changes
src/structures/chats.dto.ts— NewDeleteMessageQueryclasssrc/api/chats.controller.ts— Accept@Query()and passforMeto sessionsrc/core/abc/session.abc.ts— Updated abstract signaturesrc/core/engines/webjs/session.webjs.core.ts—message.delete(!forMe)(the actual fix)src/core/engines/noweb/session.noweb.core.ts— Signature updatesrc/core/engines/gows/session.gows.core.ts— Signature updateBackward Compatible
forMe = falseTested
forMe=true