Skip to content

Review refactoring #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
devlinmorrow wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Review refactoring #3

devlinmorrow wants to merge 6 commits into from

Conversation

@devlinmorrow
Copy link
Owner

@devlinmorrow devlinmorrow commented Sep 20, 2018

Refactorings undertaken below as suggested by my review board:

    • .idea should be removed in gitignore
  • move the ‘writing’ of the response into a responseWriter, as separate to a ResponseConstructor.
  • run tool for unused code in IntelliJ
  • default port - just have directly in ProgramArgParser itself
  • Update tests in program arg parser to be simpler.
  • replace getValueAsS with getValueAsString

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devlinmorrow