#1: implement layer dependency violations#14
Open
vlad961 wants to merge 23 commits intodevonfw-sample:violations/layerfrom
Open
#1: implement layer dependency violations#14vlad961 wants to merge 23 commits intodevonfw-sample:violations/layerfrom
vlad961 wants to merge 23 commits intodevonfw-sample:violations/layerfrom
Conversation
on any other layer.
Removed rules from ArchitectureTest.java. Because they were too restrictive. Violation of L2 - Client layer doesnt depend on any other layer.
Client Layer doesnt depend on logic layer.
Client Layer doesnt depend on dataaccess layer.
Added Violation of L8. Service layer doesnt depend on dataaccess layer.
Dataaccess layer doesnt depend on service layer.
Added Violation of L12. Dataaccess layer doesnt depend on logic layer.
Added sample tasklist and taskitem dump file.
Client layer doesnt depend on batch layer.
Service layer doesnt depend on batch layer.
Batch layer doesnt depend on service layer.
Batch layer doesnt depend on dataaccess layer.
LayerDependencyRulesTest.java includes all necessary tests.
Deleted LayerDependencyRulesTest.java. Refactored L2Violation and moved into service layer. Refactored TaskService and L9Violation to resemble to other Violations.
They equal those of add-layer-rules branch now.
hohwille
changed the title
hohwille
changed the title
Contributor
|
@vlad961 thanks for this demo PR. Very nice demonstration with good naming of |
Replaced the import script with a simple class declaration, to demonstrate dependencies towards the batch layer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE.
This fork branch contains classes demonstrating archunit layer dependency rules violations.
#1
#8
#13