[GLOBAL] fix(static-events): remove old code to pass netlify checks again#15624
Merged
nimbinatus merged 2 commits intodevopsdays:mainfrom Dec 18, 2025
Merged
[GLOBAL] fix(static-events): remove old code to pass netlify checks again#15624nimbinatus merged 2 commits intodevopsdays:mainfrom
nimbinatus merged 2 commits intodevopsdays:mainfrom
Conversation
Signed-off-by: Laura Santamaria <nimbinatus@users.noreply.github.com>
✅ Deploy Preview for devopsdays-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Laura Santamaria <nimbinatus@users.noreply.github.com>
phrawzty
approved these changes
Dec 18, 2025
Collaborator
There was a problem hiding this comment.
Going to be honest with you here: I pointed Claude Code at this and it thinks the PR is clean and ready to merge. :)
> There is a PR in `upstream`: https://github.com/devopsdays/devopsdays-web/pull/15624
It touches a _lot_ of files, and the diffs are large enough that they aren't being shown in the github web interface.
The problem is that Netlify, which does the builds of this site, is detecting "secrets" and refuses to build. The "secrets" it is detecting are old google maps keys from ancient parts
of the site. This is functionality which doesn't even exist anymore, so this PR is meant to remove not only the (stale) "secrets", but the whole google maps code blocks entirely.
Please verify the PR against the desired outcome; i.e. it's doing what we expect and not anything else.
[…]
⏺ Perfect! I've completed my review of PR #15624. Here's my analysis:
PR Summary
- Files changed: 107 files (all in static/events/YYYY-CITY/location/index.html or local/index.html)
- Scope: Archived events from 2015-2018
- Changes: 2,715 deletions, 29 additions
- Author: Laura Santamaria (@nimbinatus)
What's Being Removed ✅
The PR is doing exactly what you expected:
1. Google Maps API Key: Removing a single stale API key: AIzaSyC1bvNK9qFJGEhoWNbQuojmJJ1Tg0DoOew
2. Google Maps Code Blocks: Removing entire commented-out sections containing:
- <div id="map_canvas"> elements
- JavaScript initMap() functions that used the Google Maps API
- Script tags loading https://maps-api-ssl.google.com/maps/api/js
- Hardcoded lat/long coordinates and map initialization code
What's NOT Being Changed ✅
- No other functionality affected: The rest of the HTML files remain intact
- No sponsor information removed: All sponsor sections are preserved
- No navigation changes: Event navigation and page structure unchanged
- No other secrets or keys: Only the single Google Maps API key is being removed
Additions (The 29 lines)
The small number of additions are just:
- Whitespace adjustments (like adding <br> tags) where the Google Maps blocks were removed
- HTML continuations after the deleted sections (this is normal diff behavior)
Verdict ✅
The PR is clean and does exactly what it's supposed to do. It's systematically removing obsolete Google Maps code and the associated API key that Netlify is flagging as a "secret" from 100 archived event location pages. No unintended changes or side effects detected.
Good enough for me, tbqh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing all possible blockers to Netlify code checks from archived sites.