Conversation
✅ Deploy Preview for devspace-docs canceled.
|
f0e7c99 to
5315256
Compare
Signed-off-by: Ryan Swanson <ryan.swanson@loft.sh>
5315256 to
b9a900c
Compare
Claude reviewCritical (1) C1 — Nil dereference panic in termSizeQueueAdapter (exec.go:72) t.MonitorSize() returns nil when stdout isn't a real terminal. The old code assigned this directly to a Fix: if q := t.MonitorSize(t.GetSize()); q != nil { sizeQueue = &termSizeQueueAdapter{q: q} } High (3)
Medium (5)
Low (4)
Full details saved to claude-review.md. C1 must be fixed before merge — the nil dereference is a real |
5a48ae8 to
58fea83
Compare
58fea83 to
f40c6c7
Compare
- guard kubectl exec terminal sizing against nil queues and add adapter tests - make runtime error handler overrides resettable and add handler/formatter coverage - make devspacehelper e2e pod checks explicit after the wait loop - document CustomNavLink leaf-route matching and clean up webpack/postcss/sass config - update assets Signed-off-by: Ryan Swanson <ryan.swanson@loft.sh>
|
Lint is expected to fail due to the number of files in the commit, its finding old linting errors, despite the config for only new. |
f40c6c7 to
188d9b5
Compare
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace ...
What else do we need to know?