fix(gjc): restore Bun launcher session detection - #36
Open
chiznoir wants to merge 1 commit into
Open
Conversation
- Match the published @gajae-code/coding-agent package path. - Keep idle and transcript-backed GJC detection aligned. Tests: - TSX_TSCONFIG_PATH=server/tsconfig.json - npx tsx --test server/modules/providers/tests/live-sessions.service.test.ts
There was a problem hiding this comment.
Pull request overview
Restores correct GJC launcher/session detection by switching the packaged-entry marker back to the published @gajae-code/coding-agent scope, ensuring Bun/Node-launched gjc processes are recognized reliably.
Changes:
- Update
isGjcCommandLinedetection to match the published package marker (@gajae-code/coding-agent). - Update
isGjcProcessArgsdetection for bun/node argv[1] to match the same published marker. - Adjust live session tests to assert against the restored
@gajae-code/coding-agent/bin/gjc.jspath.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| server/modules/providers/services/live-sessions.service.ts | Restores the packaged-entry marker used to detect interpreter-launched gjc processes. |
| server/modules/providers/tests/live-sessions.service.test.ts | Updates assertions to cover the restored marker for both argv-anchored and cmdline-based detection. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
@gajae-code/coding-agentmarker used by Bun/Node GJC launchersEvidence
@gajae-code/coding-agent/bin/gjc.js4a88a12changed the detector to the nonexistent@chatmux-code/coding-agentmarker during the ChatMux rebrandVerification
TSX_TSCONFIG_PATH=server/tsconfig.json npx tsx --test server/modules/providers/tests/live-sessions.service.test.ts(63 passed)npm testcurrently reports 7 unrelated frontend loader/import failures; PR CI is authoritative for clean Node 22/24 runners