feat: orchestrator + acceptance criteria #16
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,6 @@ | ||
| url: https://bifrost.ericsiebeneich.com | ||
| realm: bifrost | ||
| orchestrate: | ||
| dispatcher: /home/devzeebo/.config/bifrost/orchestrator | ||
| concurrency: 1 | ||
| logging: verbose | ||
|
Contributor
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
rg -nP -C3 '\b(Logging|logging|Verbose|verbose)\b' --type=go -g '!**/vendor/**'
rg -nP -C3 'OrchestrateConfig|orchestrate\.' --type=go -g '!**/vendor/**'Repository: devzeebo/bifrost Length of output: 2306 🏁 Script executed: # Read the complete OrchestrateConfig struct definition
cat -n cli/orchestrate.go | sed -n '17,30p'Repository: devzeebo/bifrost Length of output: 680 🏁 Script executed: # Find YAML unmarshalling code
rg -n 'Unmarshal|mapstructure|yaml' --type=go -A3 -B3 cli/config.goRepository: devzeebo/bifrost Length of output: 1731 🏁 Script executed: # Check if Logging is referenced anywhere in the codebase
rg -n 'Logging|logging' --type=go -C2Repository: devzeebo/bifrost Length of output: 42 🏁 Script executed: # Check Viper configuration for field handling
rg -n 'v\.' cli/config.go | head -20Repository: devzeebo/bifrost Length of output: 445 🏁 Script executed: # Look for any error handling related to unknown fields
rg -n 'unknown|unmapped|extra.*field|field.*extra' --type=go -iRepository: devzeebo/bifrost Length of output: 9764 🌐 Web query:
💡 Result: The Viper library's default behavior for YAML unmarshalling regarding unknown fields is to ignore them silently. Viper reads YAML (or other formats) into its internal map[string]any representation, then uses the mapstructure library's Unmarshal (via viper.Unmarshal) to decode that map into a Go struct. By default, mapstructure ignores keys in the source map that do not match any struct fields, without error. To error on unknown fields instead, use viper.UnmarshalExact, which configures mapstructure with ErrorUnused=true, causing it to fail if there are unmapped keys. This applies specifically after YAML parsing; the YAML decoder itself (used by Viper for reading config files) is lenient and does not strict-unmarshal to structs directly—YAML goes to the map first. Citations:
Remove or implement support for The 🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Claude Orchestrator | ||
|
|
||
| Uses the Claude Agent SDK (https://code.claude.com/docs/en/agent-sdk/overview) | ||
| to create an orchestrator. This orchestrator will receive a Rune description | ||
| via stdin: | ||
|
|
||
| ```json | ||
| {"branch":"feat/test","created_at":"2026-04-10T20:23:37.222802Z","dependencies_count":0,"dependents_count":0,"id":"bf-7165","priority":0,"status":"open","tags":["worker:decompose"],"title":"Test Rune","type":"rune","updated_at":"2026-04-10T21:06:30.945272Z"} | ||
| ``` | ||
|
|
||
| We should extract the expected Agent from the tags such that | ||
| "worker:<agent-name>" invokes the "<agent-name>" agent via the Claude Code SDK, | ||
| and then wait for the completion. | ||
|
|
||
| # Architecture | ||
|
|
||
| Latest python, uv, always use latest packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid committing a developer-specific absolute path.
dispatcher: /home/devzeebo/.config/bifrost/orchestratoris a hard-coded personal path that won't resolve for any other contributor, CI agent, or docker build;bf orchestratewill fail immediately withdispatcher script not found. Since the orchestrator lives in-repo atclaude-orchestrator/dispatcher.py, point.bifrost.yamlat the in-tree script (or drop this block from the committed config and keep the absolute path in a local/untracked override).🔧 Suggested fix
📝 Committable suggestion
🤖 Prompt for AI Agents