Skip to content

feat: make error clonable #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nathanosdev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: make error clonable #563

nathanosdev wants to merge 1 commit into from

Conversation

@nathanosdev
Copy link
Contributor

@nathanosdev nathanosdev commented May 31, 2024 •
edited
Loading

Description

This makes ic_agent::Error clonable, which makes it easier for downstream clients to also make their Error types cloneable.

It's also possible to workaround by using Arc<T> in downstream clients.

I've made a related PR for Candid.

I'm currently referencing Candid by git in Cargo.toml, but of course I'll remove that if the corresponding change is agreed upon and merged in Candid.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@nathanosdev nathanosdev requested a review from a team as a code owner May 31, 2024 13:13
@nathanosdev nathanosdev mentioned this pull request May 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nathanosdev