Skip to content

chore: Cleanup - #11344

Open
michael-weigelt wants to merge 5 commits into
masterfrom
mwe/cleanup3
Open

chore: Cleanup#11344
michael-weigelt wants to merge 5 commits into
masterfrom
mwe/cleanup3

Conversation

@michael-weigelt

@michael-weigelt michael-weigelt commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Some renaming and comments.

@github-actions github-actions Bot added the chore label Aug 27, 2026
@michael-weigelt
michael-weigelt changed the base branch from mwe/remove_prefetching to master August 27, 2026 09:13
@michael-weigelt
michael-weigelt changed the base branch from master to mwe/remove_prefetching August 27, 2026 09:13
@michael-weigelt
michael-weigelt marked this pull request as ready for review August 27, 2026 09:17
@michael-weigelt
michael-weigelt requested a review from a team as a code owner August 27, 2026 09:17
@zeropath-ai

zeropath-ai Bot commented Aug 27, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 4009c54.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► rs/embedders/src/wasm_utils/system_api_replacements.rs
    Mark written pages in bytemap and enforce page limits; update documentation comments
► rs/embedders/src/wasmtime_embedder.rs
    Remove outdated comment about dirty wasm heap pages charging
► rs/embedders/tests/instrumentation.rs
    Rename overhead calculations to reflect OS-page based charging; adjust function names and comments accordingly
► rs/embedders/tests/wasmtime_random_memory_writes.rs
    Introduce and use new dmt_instructions_per_wasm_page function; update tests to compute charges via DMT per OS page
► rs/execution_environment/EXECUTION_COST.md
    Update documentation to reflect per-OS-page charging by the deterministic memory tracker and unify heap/stable memory overhead narrative
► rs/execution_environment/benches/lib/src/common.rs
    Rename and redefine overhead computation to dmt_access_instructions and dmt_write_instructions
► rs/execution_environment/benches/system_api/execute_inspect_message.rs
    Update benchmarks to use dmt_access_instructions(1) instead of previous overhead function
► rs/execution_environment/benches/system_api/execute_query.rs
    Update benchmarks to use dmt_access_instructions(1) instead of previous overhead function
► rs/execution_environment/benches/system_api/execute_update.rs
    Update benchmarks to use dmt_access_instructions and dmt_write_instructions in place of previous overhead functions
► rs/execution_environment/benches/lib/src/common.rs (additional changes)
    Adjust comments and function names to reflect new dmt_* naming

@michael-weigelt
michael-weigelt force-pushed the mwe/remove_prefetching branch 2 times, most recently from 90d70fa to f581f61 Compare August 27, 2026 12:32
@michael-weigelt
michael-weigelt changed the base branch from mwe/remove_prefetching to master August 27, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant