fix: Only complete auto progress after the certified time has been set - #11355
Open
mraszyk wants to merge 1 commit into
Open
fix: Only complete auto progress after the certified time has been set#11355mraszyk wants to merge 1 commit into
mraszyk wants to merge 1 commit into
Conversation
Enabling auto progress on a PocketIC instance spawned the progress thread and returned immediately, i.e., before the thread executed its initial `SetCertifiedTime` operation. Hence, a client could observe a stale certified time right after enabling auto progress (also when creating an instance with auto progress enabled or making an instance live). Now the progress thread signals via a oneshot channel once the certified time has been set for the first time and `ApiState::auto_progress` awaits that signal before returning. The instance locks are dropped before awaiting since the progress thread needs them to execute the operation. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling auto progress on a PocketIC instance spawned the progress thread and returned immediately, i.e., before the thread executed its initial
SetCertifiedTimeoperation. Hence, a client could observe a stale certified time right after enabling auto progress (also when creating an instance with auto progress enabled or making an instance live).Now the progress thread signals via a oneshot channel once the certified time has been set for the first time and
ApiState::auto_progressawaits that signal before returning. The instance locks are dropped before awaiting since the progress thread needs them to execute the operation.