-
Notifications
You must be signed in to change notification settings - Fork 164
Update upgrade support CTA. #3549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the upgrade support UI by replacing a Button component with a cleaner text + link approach, and simplifies the HTML structure by removing unnecessary wrapper divs and applying margins directly to elements.
- Replaced "Help & FAQ" Button with a text prompt ("Don't remember your identity number?") and a "Help" link
- Converted the primary Button component to a native HTML
<button>element - Flattened the component structure by removing nested divs and applying margins directly via Tailwind classes
Comments suppressed due to low confidence (1)
src/frontend/src/lib/components/wizards/migration/views/EnterIdentityNumber.svelte:112
- The anchor element is missing the
relattribute for security. When usingtarget="_blank", you should includerel="noopener noreferrer"to prevent the new page from accessing the window.opener property and to avoid sending the referrer information. The original Button component at this location hadrel="noopener noreferrer"which should be preserved.
<a
href={UPGRADE_SUPPORT_URL}
target="_blank"
class="text-text-primary text-sm font-semibold outline-0 hover:underline focus-visible:underline"
>
{$t`Help`}
</a>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/frontend/src/lib/components/wizards/migration/views/EnterIdentityNumber.svelte
Show resolved
Hide resolved
…dentityNumber.svelte Co-authored-by: Copilot <[email protected]>
src/frontend/src/lib/components/wizards/migration/views/EnterIdentityNumber.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/wizards/migration/views/EnterIdentityNumber.svelte
Outdated
Show resolved
Hide resolved
aterga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving modulo copy, which we're discussing offline.
Update upgrade support CTA.
Changes