feat: load custom translations from data store#953
Conversation
* feat: add urlSlug (d2config.name) to app config * feat: check datastore for custom translations * refactor: update DHIS2 locale parsing comments * refactor: move custom translations to new file * fix: use data engine for better control flow * fix: check custom translations setting (wip), await datastore result * refactor: double underscore for format * fix: check system settings before fetching translations * refactor: use debug instead of log * refactor: sonarqube recommendations * fix: version check and tests
# [12.11.0-beta.1](v12.10.4...v12.11.0-beta.1) (2026-03-02) ### Features * load custom translations from datastore ([#950](#950)) ([6053917](6053917))
| [engine, appUrlSlug] | ||
| ) | ||
|
|
||
| return getCustomTranslations |
There was a problem hiding this comment.
it might be too late to cater for this - but generally I think we're jumping over a lot of hoops to avoid having a backend change. If the backend does the check for controller and server a flag with the app (which should be easy) then this whole logic can be simplified a lot imo.
We're anyhow only supporting v43+, and we will have to backport the setting anyhow so we might as well backport such a change, to avoid shifting the complexity to the FE.
There was a problem hiding this comment.
I think it'd be worth migrating to a more robust solution as you said at some point -- do you think it'd be possible before v43?
And if not... do you think it's feasible to do this now, then improve upon it later?
(Might be worth having a call to think it through)
# [12.11.0-beta.2](v12.11.0-beta.1...v12.11.0-beta.2) (2026-03-17) ### Bug Fixes * separate error messages for fetching and loading translations ([4fb3703](4fb3703)) * use right console method, refactor custom translations hook ([0edc993](0edc993))
|
|
🎉 This PR is included in version 12.11.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
3 participants
No description provided.